Skip to content

Migrate from proposed API terminalDataWriteEvent to new terminalShellIntegration #12575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Colengms opened this issue Aug 15, 2024 · 0 comments · May be fixed by #13605
Open

Migrate from proposed API terminalDataWriteEvent to new terminalShellIntegration #12575

Colengms opened this issue Aug 15, 2024 · 0 comments · May be fixed by #13605
Labels
internal Used to opt-out an issue from having GitHub actions applied to it Language Service

Comments

@Colengms
Copy link
Contributor

My understanding is that the terminalDataWriteEvent proposed API we're using will never be published to stable and has been superseded by another feature.

The code for terminalDataWriteEvent refers to:

// https://github.com/microsoft/vscode/issues/78502
//
// This API is still proposed but we don't intent on promoting it to stable due to problems
// around performance. See #145234 for a more likely API to get stabilized.

#145234 has since been closed as completed, moving terminalShellIntegration out of proposed and into stable.

@Colengms Colengms added Language Service internal Used to opt-out an issue from having GitHub actions applied to it labels Aug 15, 2024
@Colengms Colengms moved this to Triage in cpptools Aug 20, 2024
@bobbrow bobbrow moved this from Triage to Todo in cpptools Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Used to opt-out an issue from having GitHub actions applied to it Language Service
Projects
Status: Todo
1 participant