Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.22.x doing a rename edit sometimes causes 2 tag parses of the edited files instead of 1 #12728

Closed
sean-mcmanus opened this issue Sep 18, 2024 · 0 comments
Closed

1.22.x doing a rename edit sometimes causes 2 tag parses of the edited files instead of 1 #12728

sean-mcmanus opened this issue Sep 18, 2024 · 0 comments
Assignees
@Colengms
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service performance regression A bug that didn't exist in a previous release
Milestone
1.22.4

Comments

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented Sep 18, 2024 •
edited
Loading

It doesn't repro with 1.21.6. It's possible it might not repro in all scenarios, not sure. It may repro with other edits too.

I reproed it with "files.refactoring.autoSave": false (I haven't tried with it being true).
@sean-mcmanus sean-mcmanus added bug Language Service regression A bug that didn't exist in a previous release labels Sep 18, 2024
@sean-mcmanus sean-mcmanus added this to the 1.22 milestone Sep 18, 2024
@sean-mcmanus sean-mcmanus changed the title 1.22.x doing a rename edit causes 2 tag parses of the edited files instead of 1 1.22.x doing a rename edit sometimes causes 2 tag parses of the edited files instead of 1 Sep 18, 2024
@Colengms Colengms self-assigned this Sep 18, 2024
@sean-mcmanus sean-mcmanus added the fixed Check the Milestone for the release in which the fix is or will be available. label Sep 20, 2024
@sean-mcmanus sean-mcmanus modified the milestones: 1.22, 1.22.4 Sep 20, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Colengms Colengms

Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service performance regression A bug that didn't exist in a previous release
Projects
cpptools
Status: Done
Milestone
1.22.4
Development

No branches or pull requests
2 participants
@sean-mcmanus @Colengms