Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tRPC Error Handling for WebView Communication #2517

Closed
tnaum-ms opened this issue Dec 5, 2024 · 0 comments · Fixed by #2520
Closed

Improve tRPC Error Handling for WebView Communication #2517

tnaum-ms opened this issue Dec 5, 2024 · 0 comments · Fixed by #2520
Assignees
Milestone

Comments

@tnaum-ms
Copy link
Collaborator

tnaum-ms commented Dec 5, 2024

Improve tRPC Error Handling for WebView Communication

The current tRPC implementation in the webview and VS Code extension environment may not fully support error propagation from the extension to the webview. Errors thrown on the extension side are not consistently communicated to the webview, potentially leading to unclear or incomplete error messages for the user.

Goal:
Investigate and improve error handling in the tRPC communication pipeline to ensure that errors thrown on the extension side are properly serialized and relayed to the webview.

@tnaum-ms tnaum-ms added this to the 0.24.2 milestone Dec 5, 2024
@tnaum-ms tnaum-ms self-assigned this Dec 5, 2024
@tnaum-ms tnaum-ms moved this from Planned to In progress in Azure Databases for VSCode: Release Plan Dec 9, 2024
@tnaum-ms tnaum-ms moved this from In progress to In review in Azure Databases for VSCode: Release Plan Dec 11, 2024
@tnaum-ms tnaum-ms linked a pull request Dec 11, 2024 that will close this issue
tnaum-ms added a commit that referenced this issue Dec 12, 2024
* reporting errors as a correct TRPC Error Message
* Handling TRPCErrors in webviews
* Minor telemetry error reporting update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant