Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[qt5-webengine] Build failure on x64-linux-dynamic #42895

Open
rremilian opened this issue Dec 23, 2024 · 1 comment
Open

[qt5-webengine] Build failure on x64-linux-dynamic #42895

rremilian opened this issue Dec 23, 2024 · 1 comment
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@rremilian
Copy link

rremilian commented Dec 23, 2024

Operating system

Linux

Compiler

GCC

Steps to reproduce the behavior

./vcpkg install --triplet=x64-linux-dynamic

Failure logs

When I try to install qt5-webengine, I receive this error:

../../../../src/5.15.15-8f39ffe797.clean/src/3rdparty/chromium/gpu/command_buffer/service/program_manager.cc:623:25: error: ‘using StringPiece = class absl::string_view’ {aka ‘class absl::string_view’} has no member named ‘as_string’
  623 |   return output + input.as_string();

I encountered this issue after I updated the baseline in my vcpkg.json manifest file. The version of all qt5-* packages is overridden to 5.15.15 in my manifest file.

Do you have any idea what might cause this ?

Thanks.

Additional context

No response

@rremilian rremilian added the category:port-bug The issue is with a library, which is something the port should already support label Dec 23, 2024
@rremilian
Copy link
Author

rremilian commented Dec 24, 2024

In the meantime, I created a patch for it and created a custom port for testing (found this similar issue: abseil/abseil-cpp#345)

absl-string.patch
diff --git a/src/3rdparty/chromium/gpu/command_buffer/service/program_manager.cc b/src/3rdparty/chromium/gpu/command_buffer/service/program_manager.cc
index 021530c7e..5fb3e2b76 100644
--- a/src/3rdparty/chromium/gpu/command_buffer/service/program_manager.cc
+++ b/src/3rdparty/chromium/gpu/command_buffer/service/program_manager.cc
@@ -620,7 +620,7 @@ std::string Program::ProcessLogInfo(const std::string& log) {
       output += hashed_name;
   }
 
-  return output + input.as_string();
+  return output + std::string(input);
 }
 
 void Program::UpdateLogInfo() {

It goes past the initial error, but I encounter another similar error a bit later:

../../../../src/5.15.15-f13af3fa76.clean/src/3rdparty/chromium/extensions/browser/api/web_request/form_data_parser.cc: In member function ‘virtual bool extensions::FormDataParserUrlEncoded::SetSource(base::StringPiece)’:
../../../../src/5.15.15-f13af3fa76.clean/src/3rdparty/chromium/extensions/browser/api/web_request/form_data_parser.cc:424:11: error: ‘using StringPiece = class absl::string_view’ {aka ‘class absl::string_view’} has no member named ‘set’
  424 |   source_.set(source.data(), source.size());
      |           ^~~
../../../../src/5.15.15-f13af3fa76.clean/src/3rdparty/chromium/extensions/browser/api/web_request/form_data_parser.cc: In member function ‘virtual bool extensions::FormDataParserMultipart::SetSource(base::StringPiece)’:
../../../../src/5.15.15-f13af3fa76.clean/src/3rdparty/chromium/extensions/browser/api/web_request/form_data_parser.cc:568:11: error: ‘using StringPiece = class absl::string_view’ {aka ‘class absl::string_view’} has no member named ‘set’
  568 |   source_.set(source.data(), source.size());
      |           ^~~

Later Edit: These lines were changed in the version 5.15.16 to source_ = re2::StringPiece(source.data(), source.size());.
I will try a build with version 5.15.16. The issue with as_string is still present in 5.15.16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

No branches or pull requests

2 participants