-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg-tool] Add an option to build a minimal feature set based on "default-features": false
#31298
Comments
Would be solved by microsoft/vcpkg-tool#538 |
Can you change the issue title to not say "ignore"? It is not ignored (as you have been told). It just means three different things. |
I think "ignore" sufficient because it describes the observed effect. Do you have a better word in mind? |
It has the effect it is designed to have. So I observe that it is not ignored As I said, IMO the problem is that
You expect the C behavior for B. Apart from this it is a clear situation:
|
@dg0yt Can you suggest a better title? @FrankXie05 This is not a question. My request is to implement the PR tagged by @autoantwort: microsoft/vcpkg-tool#538 |
"default-features": false
"default-features": false
I guess the best fit is: (I wouldn't use "minimum features" because |
Should be vcpkg feature. |
This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment. |
no stale |
This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 180 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment. |
no stale |
Over the years, there was a lot of confusion because
"default-features": false
is ignored in transitive dependencies: #26664 (comment) . Many users expect vcpkg to build a minimal set of features instead which does not include default features that were disabled by a port between the manifest of a user and the port declaring the default feature.In summary, we don't need to pull in disabled features if they aren't enabled by something else that didn't specify
"default-features": false
.@BillyONeal suggested to add an option to avoid unwanted features and to enable this behaviour by default in manifest mode: #11602 (comment)
Many people have fallen into this trap and the current behaviour might actually lead to longer builds rather than avoiding rebuilds.
All related issues: #31290, #31230, #30695, #26664, #24548, #17033, #11602
The text was updated successfully, but these errors were encountered: