From 7818128e8e11b93158cc59d5024b2c7d7c71d8ff Mon Sep 17 00:00:00 2001 From: Billy Robert O'Neal III Date: Wed, 23 Oct 2024 12:34:24 -0700 Subject: [PATCH] Remove cmd_execute_and_stream_data() returned debug message. We have seen no reports of broken subprocess output handling, and this message is very spammy. Given that we still have a few messages that direct end users at --debug that seems reason enough to remove spammy messages like this. --- src/vcpkg/base/system.process.cpp | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/vcpkg/base/system.process.cpp b/src/vcpkg/base/system.process.cpp index 5173864695..f8eec20da9 100644 --- a/src/vcpkg/base/system.process.cpp +++ b/src/vcpkg/base/system.process.cpp @@ -1862,14 +1862,6 @@ namespace vcpkg auto maybe_exit_code = cmd_execute_and_stream_data_impl(cmd, settings, data_cb, debug_id); const auto elapsed = timer.us_64(); g_subprocess_stats += elapsed; - if (const auto exit_code = maybe_exit_code.get()) - { - Debug::print(fmt::format("{}: cmd_execute_and_stream_data() returned {} after {:8} us\n", - debug_id, - *exit_code, - static_cast(elapsed))); - } - return maybe_exit_code; }