From 533c974a47ab9f99d458aa63ee48329878260c7c Mon Sep 17 00:00:00 2001 From: Timothee Guerin Date: Thu, 26 Oct 2023 11:41:54 -0700 Subject: [PATCH] Drop support for node 16 (#2605) fix [#1847](https://github.com/microsoft/typespec/issues/1847) --- .../bundler/upgrade-node18_2023-10-26-17-40.json | 10 ++++++++++ .../compiler/upgrade-node18_2023-10-26-17-40.json | 10 ++++++++++ .../http/upgrade-node18_2023-10-26-17-40.json | 10 ++++++++++ .../upgrade-node18_2023-10-26-17-40.json | 10 ++++++++++ .../json-schema/upgrade-node18_2023-10-26-17-40.json | 10 ++++++++++ .../migrate/upgrade-node18_2023-10-26-17-40.json | 10 ++++++++++ .../openapi/upgrade-node18_2023-10-26-17-40.json | 10 ++++++++++ .../openapi3/upgrade-node18_2023-10-26-17-40.json | 10 ++++++++++ .../playground/upgrade-node18_2023-10-26-17-40.json | 10 ++++++++++ .../rest/upgrade-node18_2023-10-26-17-40.json | 10 ++++++++++ .../versioning/upgrade-node18_2023-10-26-17-40.json | 10 ++++++++++ .../upgrade-node18_2023-10-26-17-40.json | 10 ++++++++++ .../typespec-vs/upgrade-node18_2023-10-26-17-40.json | 10 ++++++++++ eng/pipelines/pr.yml | 11 ----------- packages/best-practices/package.json | 2 +- packages/bundler/package.json | 2 +- packages/compiler/package.json | 2 +- packages/http/package.json | 2 +- packages/internal-build-utils/package.json | 2 +- packages/json-schema/package.json | 2 +- packages/lint/package.json | 2 +- packages/migrate/package.json | 2 +- packages/openapi/package.json | 2 +- packages/openapi3/package.json | 2 +- packages/playground-website/package.json | 2 +- packages/playground/package.json | 2 +- packages/rest/package.json | 2 +- packages/samples/package.json | 2 +- packages/tmlanguage-generator/package.json | 2 +- packages/tspd/package.json | 2 +- packages/typespec-vs/package.json | 2 +- packages/versioning/package.json | 2 +- 32 files changed, 148 insertions(+), 29 deletions(-) create mode 100644 common/changes/@typespec/bundler/upgrade-node18_2023-10-26-17-40.json create mode 100644 common/changes/@typespec/compiler/upgrade-node18_2023-10-26-17-40.json create mode 100644 common/changes/@typespec/http/upgrade-node18_2023-10-26-17-40.json create mode 100644 common/changes/@typespec/internal-build-utils/upgrade-node18_2023-10-26-17-40.json create mode 100644 common/changes/@typespec/json-schema/upgrade-node18_2023-10-26-17-40.json create mode 100644 common/changes/@typespec/migrate/upgrade-node18_2023-10-26-17-40.json create mode 100644 common/changes/@typespec/openapi/upgrade-node18_2023-10-26-17-40.json create mode 100644 common/changes/@typespec/openapi3/upgrade-node18_2023-10-26-17-40.json create mode 100644 common/changes/@typespec/playground/upgrade-node18_2023-10-26-17-40.json create mode 100644 common/changes/@typespec/rest/upgrade-node18_2023-10-26-17-40.json create mode 100644 common/changes/@typespec/versioning/upgrade-node18_2023-10-26-17-40.json create mode 100644 common/changes/tmlanguage-generator/upgrade-node18_2023-10-26-17-40.json create mode 100644 common/changes/typespec-vs/upgrade-node18_2023-10-26-17-40.json diff --git a/common/changes/@typespec/bundler/upgrade-node18_2023-10-26-17-40.json b/common/changes/@typespec/bundler/upgrade-node18_2023-10-26-17-40.json new file mode 100644 index 0000000000..86bb4da0b5 --- /dev/null +++ b/common/changes/@typespec/bundler/upgrade-node18_2023-10-26-17-40.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@typespec/bundler", + "comment": "**BREAKING CHANGE** Dropped support for node 16, minimum node version is now 18", + "type": "none" + } + ], + "packageName": "@typespec/bundler" +} diff --git a/common/changes/@typespec/compiler/upgrade-node18_2023-10-26-17-40.json b/common/changes/@typespec/compiler/upgrade-node18_2023-10-26-17-40.json new file mode 100644 index 0000000000..36b0785b2a --- /dev/null +++ b/common/changes/@typespec/compiler/upgrade-node18_2023-10-26-17-40.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@typespec/compiler", + "comment": "**BREAKING CHANGE** Dropped support for node 16, minimum node version is now 18", + "type": "none" + } + ], + "packageName": "@typespec/compiler" +} diff --git a/common/changes/@typespec/http/upgrade-node18_2023-10-26-17-40.json b/common/changes/@typespec/http/upgrade-node18_2023-10-26-17-40.json new file mode 100644 index 0000000000..b32ee8fc2f --- /dev/null +++ b/common/changes/@typespec/http/upgrade-node18_2023-10-26-17-40.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@typespec/http", + "comment": "**BREAKING CHANGE** Dropped support for node 16, minimum node version is now 18", + "type": "none" + } + ], + "packageName": "@typespec/http" +} diff --git a/common/changes/@typespec/internal-build-utils/upgrade-node18_2023-10-26-17-40.json b/common/changes/@typespec/internal-build-utils/upgrade-node18_2023-10-26-17-40.json new file mode 100644 index 0000000000..b5b7c58002 --- /dev/null +++ b/common/changes/@typespec/internal-build-utils/upgrade-node18_2023-10-26-17-40.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@typespec/internal-build-utils", + "comment": "**BREAKING CHANGE** Dropped support for node 16, minimum node version is now 18", + "type": "none" + } + ], + "packageName": "@typespec/internal-build-utils" +} diff --git a/common/changes/@typespec/json-schema/upgrade-node18_2023-10-26-17-40.json b/common/changes/@typespec/json-schema/upgrade-node18_2023-10-26-17-40.json new file mode 100644 index 0000000000..caa2b1be76 --- /dev/null +++ b/common/changes/@typespec/json-schema/upgrade-node18_2023-10-26-17-40.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@typespec/json-schema", + "comment": "**BREAKING CHANGE** Dropped support for node 16, minimum node version is now 18", + "type": "none" + } + ], + "packageName": "@typespec/json-schema" +} diff --git a/common/changes/@typespec/migrate/upgrade-node18_2023-10-26-17-40.json b/common/changes/@typespec/migrate/upgrade-node18_2023-10-26-17-40.json new file mode 100644 index 0000000000..54317a3cac --- /dev/null +++ b/common/changes/@typespec/migrate/upgrade-node18_2023-10-26-17-40.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@typespec/migrate", + "comment": "**BREAKING CHANGE** Dropped support for node 16, minimum node version is now 18", + "type": "none" + } + ], + "packageName": "@typespec/migrate" +} diff --git a/common/changes/@typespec/openapi/upgrade-node18_2023-10-26-17-40.json b/common/changes/@typespec/openapi/upgrade-node18_2023-10-26-17-40.json new file mode 100644 index 0000000000..5583184ea2 --- /dev/null +++ b/common/changes/@typespec/openapi/upgrade-node18_2023-10-26-17-40.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@typespec/openapi", + "comment": "**BREAKING CHANGE** Dropped support for node 16, minimum node version is now 18", + "type": "none" + } + ], + "packageName": "@typespec/openapi" +} diff --git a/common/changes/@typespec/openapi3/upgrade-node18_2023-10-26-17-40.json b/common/changes/@typespec/openapi3/upgrade-node18_2023-10-26-17-40.json new file mode 100644 index 0000000000..8b7e3161ec --- /dev/null +++ b/common/changes/@typespec/openapi3/upgrade-node18_2023-10-26-17-40.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@typespec/openapi3", + "comment": "**BREAKING CHANGE** Dropped support for node 16, minimum node version is now 18", + "type": "none" + } + ], + "packageName": "@typespec/openapi3" +} diff --git a/common/changes/@typespec/playground/upgrade-node18_2023-10-26-17-40.json b/common/changes/@typespec/playground/upgrade-node18_2023-10-26-17-40.json new file mode 100644 index 0000000000..71140f9e4a --- /dev/null +++ b/common/changes/@typespec/playground/upgrade-node18_2023-10-26-17-40.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@typespec/playground", + "comment": "**BREAKING CHANGE** Dropped support for node 16, minimum node version is now 18", + "type": "none" + } + ], + "packageName": "@typespec/playground" +} diff --git a/common/changes/@typespec/rest/upgrade-node18_2023-10-26-17-40.json b/common/changes/@typespec/rest/upgrade-node18_2023-10-26-17-40.json new file mode 100644 index 0000000000..298a150a28 --- /dev/null +++ b/common/changes/@typespec/rest/upgrade-node18_2023-10-26-17-40.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@typespec/rest", + "comment": "**BREAKING CHANGE** Dropped support for node 16, minimum node version is now 18", + "type": "none" + } + ], + "packageName": "@typespec/rest" +} diff --git a/common/changes/@typespec/versioning/upgrade-node18_2023-10-26-17-40.json b/common/changes/@typespec/versioning/upgrade-node18_2023-10-26-17-40.json new file mode 100644 index 0000000000..bb155509bb --- /dev/null +++ b/common/changes/@typespec/versioning/upgrade-node18_2023-10-26-17-40.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "@typespec/versioning", + "comment": "**BREAKING CHANGE** Dropped support for node 16, minimum node version is now 18", + "type": "none" + } + ], + "packageName": "@typespec/versioning" +} diff --git a/common/changes/tmlanguage-generator/upgrade-node18_2023-10-26-17-40.json b/common/changes/tmlanguage-generator/upgrade-node18_2023-10-26-17-40.json new file mode 100644 index 0000000000..6f145d7957 --- /dev/null +++ b/common/changes/tmlanguage-generator/upgrade-node18_2023-10-26-17-40.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "tmlanguage-generator", + "comment": "**BREAKING CHANGE** Dropped support for node 16, minimum node version is now 18", + "type": "minor" + } + ], + "packageName": "tmlanguage-generator" +} diff --git a/common/changes/typespec-vs/upgrade-node18_2023-10-26-17-40.json b/common/changes/typespec-vs/upgrade-node18_2023-10-26-17-40.json new file mode 100644 index 0000000000..6f0b0847a9 --- /dev/null +++ b/common/changes/typespec-vs/upgrade-node18_2023-10-26-17-40.json @@ -0,0 +1,10 @@ +{ + "changes": [ + { + "packageName": "typespec-vs", + "comment": "**BREAKING CHANGE** Dropped support for node 16, minimum node version is now 18", + "type": "none" + } + ], + "packageName": "typespec-vs" +} diff --git a/eng/pipelines/pr.yml b/eng/pipelines/pr.yml index d21b022474..6596467c52 100644 --- a/eng/pipelines/pr.yml +++ b/eng/pipelines/pr.yml @@ -14,17 +14,6 @@ jobs: strategy: matrix: - # Node 16 - "Linux - Node 16.x": - pool: azsdk-pool-mms-ubuntu-2004-general - imageName: ubuntu-20.04 - nodeVersion: "16.x" - - "Windows - Node 16.x": - pool: azsdk-pool-mms-win-2022-general - imageName: windows-2022 - nodeVersion: "16.x" - # Node 18 "Linux - Node 18.x": pool: azsdk-pool-mms-ubuntu-2004-general diff --git a/packages/best-practices/package.json b/packages/best-practices/package.json index 94e4f3bdd9..be25f2e6d7 100644 --- a/packages/best-practices/package.json +++ b/packages/best-practices/package.json @@ -22,7 +22,7 @@ ".": "./dist/src/index.js" }, "engines": { - "node": ">=16.0.0" + "node": ">=18.0.0" }, "scripts": { "clean": "rimraf ./dist ./temp", diff --git a/packages/bundler/package.json b/packages/bundler/package.json index c0b68ce3d9..d8e1a3f743 100644 --- a/packages/bundler/package.json +++ b/packages/bundler/package.json @@ -20,7 +20,7 @@ "main": "dist/src/index.js", "tspMain": "dist/src/index.js", "engines": { - "node": ">=16.0.0" + "node": ">=18.0.0" }, "scripts": { "bundle": "node ./dist/src/cli.js", diff --git a/packages/compiler/package.json b/packages/compiler/package.json index fc38926b95..d9bb699a4d 100644 --- a/packages/compiler/package.json +++ b/packages/compiler/package.json @@ -47,7 +47,7 @@ } }, "engines": { - "node": ">=16.0.0" + "node": ">=18.0.0" }, "bin": { "tsp": "cmd/tsp.js", diff --git a/packages/http/package.json b/packages/http/package.json index 7317572332..4b97910b2b 100644 --- a/packages/http/package.json +++ b/packages/http/package.json @@ -34,7 +34,7 @@ } }, "engines": { - "node": ">=16.0.0" + "node": ">=18.0.0" }, "scripts": { "clean": "rimraf ./dist ./temp", diff --git a/packages/internal-build-utils/package.json b/packages/internal-build-utils/package.json index 604758d417..d8051a843e 100644 --- a/packages/internal-build-utils/package.json +++ b/packages/internal-build-utils/package.json @@ -22,7 +22,7 @@ "typespec-build-tool": "cmd/cli.js" }, "engines": { - "node": ">=16.0.0" + "node": ">=18.0.0" }, "scripts": { "clean": "rimraf ./dist ./temp", diff --git a/packages/json-schema/package.json b/packages/json-schema/package.json index c267d259ad..4f78f2ffd0 100644 --- a/packages/json-schema/package.json +++ b/packages/json-schema/package.json @@ -24,7 +24,7 @@ }, "tspMain": "lib/main.tsp", "engines": { - "node": ">=16.0.0" + "node": ">=18.0.0" }, "scripts": { "clean": "rimraf ./dist ./temp", diff --git a/packages/lint/package.json b/packages/lint/package.json index b54eaa1415..aacb911a76 100644 --- a/packages/lint/package.json +++ b/packages/lint/package.json @@ -34,7 +34,7 @@ } }, "engines": { - "node": ">=16.0.0" + "node": ">=18.0.0" }, "scripts": { "clean": "rimraf ./dist ./temp", diff --git a/packages/migrate/package.json b/packages/migrate/package.json index d54fdbc797..10f02d41c7 100644 --- a/packages/migrate/package.json +++ b/packages/migrate/package.json @@ -22,7 +22,7 @@ "typespec-migrate": "./dist/src/cli.js" }, "engines": { - "node": ">=16.0.0" + "node": ">=18.0.0" }, "scripts": { "clean": "rimraf ./dist ./temp", diff --git a/packages/openapi/package.json b/packages/openapi/package.json index 4eb69894c1..138b3b696d 100644 --- a/packages/openapi/package.json +++ b/packages/openapi/package.json @@ -34,7 +34,7 @@ } }, "engines": { - "node": ">=16.0.0" + "node": ">=18.0.0" }, "scripts": { "clean": "rimraf ./dist ./temp", diff --git a/packages/openapi3/package.json b/packages/openapi3/package.json index 092e95b3ad..08065a4a9e 100644 --- a/packages/openapi3/package.json +++ b/packages/openapi3/package.json @@ -34,7 +34,7 @@ } }, "engines": { - "node": ">=16.0.0" + "node": ">=18.0.0" }, "scripts": { "clean": "rimraf ./dist ./temp", diff --git a/packages/playground-website/package.json b/packages/playground-website/package.json index 8b320e09d6..61dea14f82 100644 --- a/packages/playground-website/package.json +++ b/packages/playground-website/package.json @@ -20,7 +20,7 @@ "type": "module", "main": "dist/src/lib.js", "engines": { - "node": ">=16.0.0" + "node": ">=18.0.0" }, "scripts": { "clean": "rimraf ./dist ./dist-dev ./temp ./typespecContents.json", diff --git a/packages/playground/package.json b/packages/playground/package.json index 3c615879c7..33900e0f05 100644 --- a/packages/playground/package.json +++ b/packages/playground/package.json @@ -26,7 +26,7 @@ "./react/viewers": "./dist/src/react/viewers.js" }, "engines": { - "node": ">=16.0.0" + "node": ">=18.0.0" }, "scripts": { "clean": "rimraf ./dist ./dist-dev ./temp ./typespecContents.json", diff --git a/packages/rest/package.json b/packages/rest/package.json index 0ecb6ace7e..331d536be5 100644 --- a/packages/rest/package.json +++ b/packages/rest/package.json @@ -34,7 +34,7 @@ } }, "engines": { - "node": ">=16.0.0" + "node": ">=18.0.0" }, "scripts": { "clean": "rimraf ./dist ./temp", diff --git a/packages/samples/package.json b/packages/samples/package.json index fcd8901ddc..2e2ac3dd55 100644 --- a/packages/samples/package.json +++ b/packages/samples/package.json @@ -26,7 +26,7 @@ } }, "engines": { - "node": ">=16.0.0" + "node": ">=18.0.0" }, "scripts": { "clean": "rimraf ./dist ./temp", diff --git a/packages/tmlanguage-generator/package.json b/packages/tmlanguage-generator/package.json index 6298f0bd5f..ea6b081ad0 100644 --- a/packages/tmlanguage-generator/package.json +++ b/packages/tmlanguage-generator/package.json @@ -19,7 +19,7 @@ ], "main": "dist/tmlanguage-generator.js", "engines": { - "node": ">=16.0.0" + "node": ">=18.0.0" }, "scripts": { "clean": "rimraf ./dist ./temp", diff --git a/packages/tspd/package.json b/packages/tspd/package.json index d7b9ff1fb5..67920c0e47 100644 --- a/packages/tspd/package.json +++ b/packages/tspd/package.json @@ -36,7 +36,7 @@ } }, "engines": { - "node": ">=16.0.0" + "node": ">=18.0.0" }, "scripts": { "clean": "rimraf ./dist ./temp", diff --git a/packages/typespec-vs/package.json b/packages/typespec-vs/package.json index 39fab28402..c35a539815 100644 --- a/packages/typespec-vs/package.json +++ b/packages/typespec-vs/package.json @@ -18,7 +18,7 @@ ], "type": "module", "engines": { - "node": ">=16.0.0" + "node": ">=18.0.0" }, "files": [ "Microsoft.TypeSpec.VS.vsix" diff --git a/packages/versioning/package.json b/packages/versioning/package.json index de6954105a..0b09981763 100644 --- a/packages/versioning/package.json +++ b/packages/versioning/package.json @@ -34,7 +34,7 @@ } }, "engines": { - "node": ">=16.0.0" + "node": ">=18.0.0" }, "scripts": { "clean": "rimraf ./dist ./temp",