Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RS-DEF-PROP] Enhance Eventhouse resource by adding definition support #135

Open
1 of 11 tasks
DariuszPorowski opened this issue Dec 9, 2024 · 0 comments · May be fixed by #166
Open
1 of 11 tasks

[RS-DEF-PROP] Enhance Eventhouse resource by adding definition support #135

DariuszPorowski opened this issue Dec 9, 2024 · 0 comments · May be fixed by #166
Labels
enhancement Enhancement to existing feature tf/resource Terraform Resource type/RS-DEF-PROP Fabric Item resource with definition and properties
Milestone

Comments

@DariuszPorowski
Copy link
Member

DariuszPorowski commented Dec 9, 2024

📝 Description

When I am managing my Infrastructure as Code using Terraform for Eventhouse. I want to be able to manage Eventhouse definition. So, I can automate the deployment and configuration of my Eventhouse definition, ensuring consistency, and reducing manual effort.

🔬 Details / References

🚧 Potential Terraform Configuration / Desired Solution

# Example 1 - Eventhouse without definition
resource "fabric_eventhouse" "example" {
  display_name = "example"
  workspace_id = "00000000-0000-0000-0000-000000000000"
}

# Example 2 - Eventhouse with definition bootstrapping only
resource "fabric_eventhouse" "example_definition_bootstrap" {
  display_name              = "example"
  description               = "example with definition bootstrapping"
  workspace_id              = "00000000-0000-0000-0000-000000000000"
  definition_update_enabled = false
  definition = {
    "EventhouseProperties.json" = {
      source = "${local.path}/EventhouseProperties.json.tmpl"
    }
  }
}

# Example 3 - Eventhouse with definition update when source or tokens changed
resource "fabric_eventhouse" "example_definition_update" {
  display_name = "example"
  description  = "example with definition update when source or tokens changed"
  workspace_id = "00000000-0000-0000-0000-000000000000"
  definition = {
    "EventhouseProperties.json" = {
      source = "${local.path}/EventhouseProperties.json.tmpl"
      tokens = {
        "MESSAGE" = "World"
        "MyValue" = "Lorem Ipsum"
      }
    }
  }
}

📎 Additional context

  • Definition is optional
  • Format is N/A
  • Empty definition part with Fabric path EventhouseProperties.json contains: {}

☑️ Acceptance Criteria

The end user will be able to:

  • Manage Eventhouse without definition
  • Manage Eventhouse with definition in the bootstrapping mode only
  • Manage Eventhouse with definition updates when source of the definition or used tokens changed

✅ Definition of Done

  • Data Transfer Objects (DTOs)
  • Data Client functions
  • Resource Implementation
  • Resource Added to Provider
  • Unit Tests for Happy path
  • Unit Tests for Error path
  • Acceptance Tests
  • Example in the ./examples folder
  • Schema documentation in code
  • Updated auto-generated provider docs with task docs

🔰 Code of Conduct

  • I agree to follow this project's Code of Conduct.
@DariuszPorowski DariuszPorowski added enhancement Enhancement to existing feature feature New feature or request tf/resource Terraform Resource labels Dec 9, 2024
@DariuszPorowski DariuszPorowski changed the title [RS-PROP-DEF] Enhance Eventhouse resource by adding definition support [RS-DEF-PROP] Enhance Eventhouse resource by adding definition support Dec 18, 2024
@DariuszPorowski DariuszPorowski added type/RS-DEF-PROP Fabric Item resource with definition and properties and removed feature New feature or request labels Dec 18, 2024
@DariuszPorowski DariuszPorowski linked a pull request Dec 20, 2024 that will close this issue
@DariuszPorowski DariuszPorowski added this to the 2025-01 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature tf/resource Terraform Resource type/RS-DEF-PROP Fabric Item resource with definition and properties
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant