Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider using a smaller command line argument parser #69

Open
lhecker opened this issue May 1, 2024 · 0 comments
Open

Consider using a smaller command line argument parser #69

lhecker opened this issue May 1, 2024 · 0 comments
Labels
Issue-Task It's a feature request, but it doesn't really need a major design.
Milestone
24H2

Comments

@lhecker
Copy link
Member

lhecker commented May 1, 2024 •
edited
Loading

clap constitutes roughly 80% of sudo's binary size. According to this we have various choices that are significantly smaller:
https://github.com/rosetta-rs/argparse-rosetta-rs#results

Among those, pico-args seems to be the 2nd most popular choice and it's 30x smaller and 10x faster to compile. argh was authored by Google and may receive continued support as well. This clap issue seems relevant: clap-rs/clap#1365

Since other, smaller parsers often don't support builtin formatting for --help we'd probably have to write that ourselves, however for sudo I suspect a simple, static string is sufficient.
@lhecker lhecker added the Issue-Task It's a feature request, but it doesn't really need a major design. label May 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 1, 2024
@joadoumie joadoumie removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 29, 2024
@joadoumie joadoumie added this to the 24H2 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Issue-Task It's a feature request, but it doesn't really need a major design.
Projects
None yet
Milestone
24H2
Development

No branches or pull requests
2 participants
@lhecker @joadoumie