Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Global Logger #585

Open
timraymond opened this issue Aug 7, 2024 · 0 comments
Open

Remove the Global Logger #585

timraymond opened this issue Aug 7, 2024 · 0 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed lang/go The Go Programming Language priority/2 P2 scope/S Change is Small type/enhancement New feature or request

Comments

@timraymond
Copy link
Member

We currently have a global logger in retinacmd.Logger. There's never a need for a global logger, and it inhibits the proper use of "child loggers", where certain contextual information is injected into scope-limited logger instances (helping to ensure consistent logging without overhead). We should remove the global logger and inject it in every instance.
@timraymond timraymond mentioned this issue Aug 7, 2024
Open
7 tasks
@rbtr rbtr added type/enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed lang/go The Go Programming Language priority/2 P2 scope/S Change is Small labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed lang/go The Go Programming Language priority/2 P2 scope/S Change is Small type/enhancement New feature or request
Projects
Retina Triage Board
Status: Accepted
Milestone
No milestone
Development

No branches or pull requests
2 participants
@timraymond @rbtr