Errors when using ExternalName or Headless services #547
Assignees
Labels
Comments
|
Confirmed this as an issue with our Headless services as well. |
7 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 24, 2024
# Description * update service controller to ignore headless svc and re-trigger reconcile when encountering one * create test to validate UpdateRetinaSvc still throws an error if a retina svc has no IPv4 (this is to make sure existing validation post retinaSvc creation is not broken) ## Related Issue If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request. fix #547 ## Checklist - [x] I have read the [contributing documentation](https://retina.sh/docs/contributing). - [x] I signed and signed-off the commits (`git commit -S -s ...`). See [this documentation](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification) on signing commits. - [x] I have correctly attributed the author(s) of the code. - [x] I have tested the changes locally. - [x] I have followed the project's style guidelines. - [x] I have updated the documentation, if necessary. - [x] I have added tests, if applicable. ## Screenshots (if applicable) or Testing Completed Please add any relevant screenshots or GIFs to showcase the changes made. ## Additional Notes Add any additional notes or context about the pull request here. --- Please refer to the [CONTRIBUTING.md](../CONTRIBUTING.md) file for more information on how to contribute to this project. Signed-off-by: Simone Rodigari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Retina agents log a lot of error messages when having headless service in the cluster or of type ExternalName.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Retina should just ignore those services (or use endpoint ips of headless service?)
Platform (please complete the following information):
Additional Information:
I guess the relevant code is this, where it tries to save ClusterIP, even though not all services is k8s have a ClusterIP
retina/pkg/controllers/daemon/service/controller.go
Line 78 in b71ec00
retina/pkg/common/service.go
Line 46 in b71ec00
The text was updated successfully, but these errors were encountered: