fix: daemon listen for SIGTERM and SIGINIT to gracefully clean up and shutdown #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbtr
reviewed
Jul 29, 2024
| go func() { | ||
| sig := <-sigChan | ||
| mainLogger.Info("Received signal, stopping controller manager", zap.String("signal", sig.String())) | ||
| controllerMgr.Stop(ctx) |
There was a problem hiding this comment.
I think it's cleaner to pass the context to (everything), and then cancel the context in the signal handler to cause cascading graceful shutdown.
controller-runtime also provides a cross-platform helper which we could use.
There was a problem hiding this comment.
ok nvm, apparently, we are using SetupSignalHandler and passing down the returned ctx already 🥲, and also TIL it is not a good idea to test with kill -9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #537. Explanation in issue.
Related Issue
If this pull request is related to any issue, please mention it here. Additionally, make sure that the issue is assigned to you before submitting this pull request.
Checklist
git commit -S -s ...). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.