Update testlib.cpp

Author: anupriya13

vnext/ReactCommon/TEMP_UntilReactCommonUpdate/jsi/jsi/test/testlib.cpp

@@ -1488,48 +1488,44 @@ TEST_P(JSITest, NativeState) {
       std::dynamic_pointer_cast<IntState>(holder.getNativeState(rt))->value,
       21);
 
-  // There's currently way to "delete" the native state of a component fully
-  // Even when reset with nullptr, hasNativeState will still return true
-  // TODO: Make it pass for Hermes and V8
-  // holder.setNativeState(rt, nullptr);
-  // EXPECT_TRUE(holder.hasNativeState(rt));
-  // EXPECT_TRUE(holder.getNativeState(rt) == nullptr);
+  holder.setNativeState(rt, nullptr);
+  EXPECT_TRUE(holder.hasNativeState(rt));
+  EXPECT_TRUE(holder.getNativeState(rt) == nullptr);
 }
 
-// TODO: Make it pass on Hermes
-// TEST_P(JSITest, NativeStateSymbolOverrides) {
-//   Object holder(rt);
-
-//   auto stateValue = std::make_shared<IntState>(42);
-//   holder.setNativeState(rt, stateValue);
-
-//   // Attempting to change configurable attribute of unconfigurable property
-//   try {
-//     function(
-//         "function (obj) {"
-//         "  var mySymbol = Symbol();"
-//         "  obj[mySymbol] = 'foo';"
-//         "  var allSymbols = Object.getOwnPropertySymbols(obj);"
-//         "  for (var sym of allSymbols) {"
-//         "    Object.defineProperty(obj, sym, {configurable: true, writable:
-//         true});" "    obj[sym] = 'bar';" "  }"
-//         "}")
-//         .call(rt, holder);
-//   } catch (const JSError& ex) {
-//     // On JSC this throws, but it doesn't on Hermes
-//     std::string exc = ex.what();
-//     EXPECT_NE(
-//         exc.find(
-//             "Attempting to change configurable attribute of unconfigurable
-//             property"),
-//         std::string::npos);
-//   }
-
-//   EXPECT_TRUE(holder.hasNativeState(rt));
-//   EXPECT_EQ(
-//       std::dynamic_pointer_cast<IntState>(holder.getNativeState(rt))->value,
-//       42);
-// }
+TEST_P(JSITest, NativeStateSymbolOverrides) {
+  Object holder(rt);
+
+  auto stateValue = std::make_shared<IntState>(42);
+  holder.setNativeState(rt, stateValue);
+
+  // Attempting to change configurable attribute of unconfigurable property
+  try {
+    function(
+        "function (obj) {"
+        "  var mySymbol = Symbol();"
+        "  obj[mySymbol] = 'foo';"
+        "  var allSymbols = Object.getOwnPropertySymbols(obj);"
+        "  for (var sym of allSymbols) {"
+        "    Object.defineProperty(obj, sym, {configurable: true, writable:
+        true});" "    obj[sym] = 'bar';" "  }"
+        "}")
+        .call(rt, holder);
+  } catch (const JSError& ex) {
+    // On JSC this throws, but it doesn't on Hermes
+    std::string exc = ex.what();
+    EXPECT_NE(
+        exc.find(
+            "Attempting to change configurable attribute of unconfigurable
+            property"),
+        std::string::npos);
+  }
+
+  EXPECT_TRUE(holder.hasNativeState(rt));
+  EXPECT_EQ(
+      std::dynamic_pointer_cast<IntState>(holder.getNativeState(rt))->value,
+      42);
+}
 
 TEST_P(JSITest, UTF8ExceptionTest) {
   // Test that a native exception containing UTF-8 characters is correctly
@@ -1550,7 +1546,6 @@ TEST_P(JSITest, UTF8ExceptionTest) {
   }
 }
 
-/* [Windows #14185
 TEST_P(JSITest, UTF16ConversionTest) {
   // This Runtime Decorator is used to test the conversion from UTF-8 to UTF-16
   // in the default utf16 method for runtimes that do not provide their own
@@ -1658,10 +1653,8 @@ TEST_P(JSITest, CreateFromUtf16Test) {
   auto cp = eval("loneSurrogate.charCodeAt(0)").getNumber();
   EXPECT_EQ(cp, 55357); // 0xD83D in decimal
 }
-Windows] */
+Windows]
 
-/*
-[Windows 
 TEST_P(JSITest, GetStringDataTest) {
   // This Runtime Decorator is used to test the default getStringData
   // implementation for VMs that do not provide their own implementation
@@ -1750,7 +1743,6 @@ TEST_P(JSITest, ObjectCreateWithPrototype) {
   child = Object::create(rd, Value::null());
   EXPECT_TRUE(child.getPrototype(rd).isNull());
 }
-Windows] */
 
 INSTANTIATE_TEST_CASE_P(
     Runtimes,