Update rust to v1.84.0 (#2107)

This PR updates the Rust version to 1.84.0.

To fix some new clippy lints I had to upgrade `PyO3` to its latest
version, this led to `PyO3` related changes.
For the same reason I had to update `wasm_bindgen` to its latest
version, but no further changes were required.

Author: orpuente-MS

.ado/publish.yml

@@ -19,7 +19,7 @@ schedules:
 
 variables:
   CARGO_TERM_COLOR: always
-  RUST_TOOLCHAIN_VERSION: "1.82"
+  RUST_TOOLCHAIN_VERSION: "1.84"
 
 resources:
   repositories:

.github/workflows/bench-reports.yml

@@ -8,7 +8,7 @@ env:
   CARGO_TERM_COLOR: always
   NODE_VERSION: "18.17.1"
   PYTHON_VERSION: "3.11"
-  RUST_TOOLCHAIN_VERSION: "1.82"
+  RUST_TOOLCHAIN_VERSION: "1.84"
 
 jobs:
   runBenchmark:

.github/workflows/ci.yml

@@ -20,7 +20,7 @@ env:
   CARGO_TERM_COLOR: always
   NODE_VERSION: "18.17.1"
   PYTHON_VERSION: "3.11"
-  RUST_TOOLCHAIN_VERSION: "1.82"
+  RUST_TOOLCHAIN_VERSION: "1.84"
   RUST_TOOLCHAIN_COMPONENTS: rustfmt clippy
 
 jobs:

.github/workflows/memory_profile.yml

@@ -15,7 +15,7 @@ env:
   CARGO_TERM_COLOR: always
   NODE_VERSION: "18.17.1"
   PYTHON_VERSION: "3.11"
-  RUST_TOOLCHAIN_VERSION: "1.82"
+  RUST_TOOLCHAIN_VERSION: "1.84"
   RUST_TOOLCHAIN_COMPONENTS: rustfmt clippy
 
 jobs:

.github/workflows/publish-playground.yml

@@ -11,7 +11,7 @@ on:
 
 env:
   CARGO_TERM_COLOR: always
-  RUST_TOOLCHAIN_VERSION: "1.82"
+  RUST_TOOLCHAIN_VERSION: "1.84"
   RUST_TOOLCHAIN_COMPONENTS: rustfmt clippy
 
 # Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages

Cargo.lock

@@ -73,11 +73,11 @@ regex-lite = "0.1"
 rustc-hash = "1"
 serde = { version = "1.0", features = [ "derive" ] }
 serde-wasm-bindgen = "0.6"
-wasm-bindgen = "0.2"
+wasm-bindgen = "0.2.100"
 wasm-bindgen-futures = "0.4"
 rand = "0.8"
 serde_json = "1.0"
-pyo3 = "0.22"
+pyo3 = "0.23.4"
 quantum-sparse-sim = { git = "https://github.com/qir-alliance/qir-runner", rev = "562e2c11ad685dd01bfc1ae975e00d4133615995" }
 async-trait = "0.1"
 tokio = { version = "1.35", features = ["macros", "rt"] }

Cargo.toml

@@ -19,8 +19,8 @@ impl<E> WithStack<E> {
         WithStack { error, stack_trace }
     }
 
-    pub(super) fn stack_trace(&self) -> &Option<String> {
-        &self.stack_trace
+    pub(super) fn stack_trace(&self) -> Option<&String> {
+        self.stack_trace.as_ref()
     }
 
     pub fn error(&self) -> &E {

compiler/qsc/src/error.rs

@@ -71,10 +71,10 @@ use thiserror::Error;
 
 impl Error {
     #[must_use]
-    pub fn stack_trace(&self) -> &Option<String> {
+    pub fn stack_trace(&self) -> Option<&String> {
         match &self {
             Error::Eval(err) => err.stack_trace(),
-            _ => &None,
+            _ => None,
         }
     }
 }

compiler/qsc/src/interpret.rs

@@ -89,7 +89,6 @@ fn stack_traces_can_cross_eval_session_and_file_boundaries() {
         Err(e) => {
             let stack_trace = e[0]
                 .stack_trace()
-                .as_ref()
                 .expect("code should have a valid stack trace");
             let expectation = indoc! {r#"
                          Error: division by zero
@@ -161,7 +160,6 @@ fn stack_traces_can_cross_file_and_entry_boundaries() {
         Err(e) => {
             let stack_trace = e[0]
                 .stack_trace()
-                .as_ref()
                 .expect("code should have a valid stack trace");
             let expectation = indoc! {r#"
                          Error: division by zero