Pyright can't detect return value is not None...

[apocalypse2012]

The following code report an error on any value returned by get_resources() that is treated like a dict.

Pyright: "values" is not a known attribute of "None"

There is no way to return a None value from that method and it is annotated to reflect that. How do keep this from occurring? I see no way for a None value to fall through...

    def get_resources(self, labels=None) -> Dict[str, Any]:
        labels = labels if labels and hasattr(labels, "__iter__") else None
        if not labels:
            return dict(self.resources)
        resource_dict = {
            label: resource_inst
            for label, resource_inst in dict(self.resources).items()
            if label in labels
        }
        return resource_dict if resource_dict else dict(self.resources)

    def is_dirty(self) -> bool:
        resource_dict = self.get_resources()
        the_resources = resource_dict.values()
        this_dirty = all(res.is_dirty() for res in the_resources)
        return this_dirty

[erictraut]

I presume this code is part of a class and that resources is an attribute with some iterable type?

Here's my attempt to repro the issue based on the code you've provided. Pyright doesn't generate any type errors in this case, so there must be some missing details.