Description
Version
Steps to reproduce
open codegen and generate aria snapshot for getting started link(green button)
Expected behavior
- I expected the aria tab to show me something
- We would like to add a placeholder like
Use 'Pick Locator'...
- We would like to add a placeholder like
-
expected trace viewer to show me a tab with the aria snapshots perhaps- waiting for more feedback for now
- expect.toMatchAriaSnapshot -> expect(page).toMatchAriaSnapshot
-
I expected codegen to generate a working example for the get started link yet it did not! -
Thoughts: aria snapshot tab only in codegen but not in trace viewer and ui mode. Is this correct? What about when using VS Code extension? Should we tell people to use codegen instead of extension when using aria snapshots cause it will have a tab where when working you will see the snapshots?- waiting for more feedback
- does update snapshots give you any message to say that it worked? how do you know it did anything?
- for ui mode the expand all button can we not just make one button that toggles between the expands?
- follow-up: fix collapsable log
Actual behavior
opening codegen to generate ariasnapshots.
-
When recording there is an aria snapshots tab but it remained blank
-
The log now has arrows to expand downwards but there seems nothing to expand
-
When trying to get the aria snapshot for the getting started button/link on the home page it gives role of banner. Why does it not generate a getByRole('link')??
await expect(page.getByRole('banner')).toMatchAriaSnapshot(- link "Get started")
Additional context
Environment
System:
OS: macOS 15.1
CPU: (10) arm64 Apple M1 Max
Memory: 709.84 MB / 64.00 GB
Binaries:
Node: 20.11.1 - /usr/local/bin/node
Yarn: 1.22.19 - /usr/local/bin/yarn
npm: 10.2.4 - /usr/local/bin/npm
pnpm: 8.5.0 - /usr/local/bin/pnpm
IDEs:
VSCode: 1.95.1 - /usr/local/bin/code
Languages:
Bash: 3.2.57 - /bin/bash
npmPackages:
@playwright/test: ^1.49.0-alpha-2024-11-07 => 1.49.0-alpha-2024-11-07