Merge branch 'microsoft:main' into custom-iterator-for-faster-stack-trace

Author: neoncube2

.github/workflows/test_docker.yml

@@ -19,13 +19,16 @@ on:
 jobs:
   build:
     timeout-minutes: 120
-    runs-on: ubuntu-24.04
+    runs-on: ${{ matrix.runs-on }}
     strategy:
       fail-fast: false
       matrix:
         docker-image-variant:
           - jammy
           - noble
+        runs-on:
+          - ubuntu-24.04
+          - ubuntu-24.04-arm
     steps:
     - uses: actions/checkout@v4
     - name: Set up Python
@@ -39,10 +42,12 @@ jobs:
         pip install -r requirements.txt
         pip install -e .
     - name: Build Docker image
-      run: bash utils/docker/build.sh --amd64 ${{ matrix.docker-image-variant }} playwright-python:localbuild-${{ matrix.docker-image-variant }}
+      run: |
+        ARCH="${{ matrix.runs-on == 'ubuntu-24.04-arm' && 'arm64' || 'amd64' }}"
+        bash utils/docker/build.sh --$ARCH ${{ matrix.docker-image-variant }} playwright-python:localbuild-${{ matrix.docker-image-variant }}
     - name: Test
       run: |
-        CONTAINER_ID="$(docker run --rm -v $(pwd):/root/playwright --name playwright-docker-test --workdir /root/playwright/ -d -t playwright-python:localbuild-${{ matrix.docker-image-variant }} /bin/bash)"
+        CONTAINER_ID="$(docker run --rm -e CI -v $(pwd):/root/playwright --name playwright-docker-test --workdir /root/playwright/ -d -t playwright-python:localbuild-${{ matrix.docker-image-variant }} /bin/bash)"
         # Fix permissions for Git inside the container
         docker exec "${CONTAINER_ID}" chown -R root:root /root/playwright
         docker exec "${CONTAINER_ID}" pip install -r local-requirements.txt

.github/workflows/trigger_internal_tests.yml

@@ -171,7 +171,7 @@ def _user_data_dir(self, userDataDir: Optional[Union[str, Path]]) -> str:
             # Can be dropped once we drop Python 3.9 support (10/2025):
             # https://github.com/python/cpython/issues/82852
             if sys.platform == "win32" and sys.version_info[:2] < (3, 10):
-                return pathlib.Path.cwd() / userDataDir
+                return str(pathlib.Path.cwd() / userDataDir)
             return str(Path(userDataDir).resolve())
         return str(Path(userDataDir))
 

playwright/_impl/_browser_type.py

@@ -99,7 +99,8 @@ def extractall(zip: zipfile.ZipFile, path: str) -> None:
 
 def download_driver(zip_name: str) -> None:
     zip_file = f"playwright-{driver_version}-{zip_name}.zip"
-    if os.path.exists("driver/" + zip_file):
+    destination_path = "driver/" + zip_file
+    if os.path.exists(destination_path):
         return
     url = "https://playwright.azureedge.net/builds/driver/"
     if (
@@ -109,9 +110,11 @@ def download_driver(zip_name: str) -> None:
     ):
         url = url + "next/"
     url = url + zip_file
+    temp_destination_path = destination_path + ".tmp"
     print(f"Fetching {url}")
     # Don't replace this with urllib - Python won't have certificates to do SSL on all platforms.
-    subprocess.check_call(["curl", url, "-o", "driver/" + zip_file])
+    subprocess.check_call(["curl", url, "-o", temp_destination_path])
+    os.rename(temp_destination_path, destination_path)
 
 
 class PlaywrightBDistWheelCommand(BDistWheelCommand):

setup.py

@@ -27,6 +27,10 @@
 def _test_signals_async(
     browser_name: str, launch_arguments: Dict, wait_queue: "multiprocessing.Queue[str]"
 ) -> None:
+    # On Windows, hint to mypy and pyright that they shouldn't check this function
+    if sys.platform == "win32":
+        return
+
     os.setpgrp()
     sigint_received = False
 
@@ -67,6 +71,10 @@ async def main() -> None:
 def _test_signals_sync(
     browser_name: str, launch_arguments: Dict, wait_queue: "multiprocessing.Queue[str]"
 ) -> None:
+    # On Windows, hint to mypy and pyright that they shouldn't check this function
+    if sys.platform == "win32":
+        return
+
     os.setpgrp()
     sigint_received = False
 
@@ -103,6 +111,10 @@ def my_sig_handler(signum: int, frame: Any) -> None:
 def _create_signals_test(
     target: Any, browser_name: str, launch_arguments: Dict
 ) -> None:
+    # On Windows, hint to mypy and pyright that they shouldn't check this function
+    if sys.platform == "win32":
+        return
+
     wait_queue: "multiprocessing.Queue[str]" = multiprocessing.Queue()
     process = multiprocessing.Process(
         target=target, args=[browser_name, launch_arguments, wait_queue]