fix(context): allow defaultBrowserType keyword (#196)

Author: mxschmitt

playwright/async_api.py

@@ -5364,6 +5364,7 @@ async def newContext(
         hasTouch: bool = None,
         colorScheme: Literal["light", "dark", "no-preference"] = None,
         acceptDownloads: bool = None,
+        defaultBrowserType: str = None,
     ) -> "BrowserContext":
         """Browser.newContext
 
@@ -5428,6 +5429,7 @@ async def newContext(
                 hasTouch=hasTouch,
                 colorScheme=colorScheme,
                 acceptDownloads=acceptDownloads,
+                defaultBrowserType=defaultBrowserType,
             )
         )
 

playwright/browser.py

@@ -83,8 +83,13 @@ async def newContext(
         hasTouch: bool = None,
         colorScheme: ColorScheme = None,
         acceptDownloads: bool = None,
+        defaultBrowserType: str = None,
     ) -> BrowserContext:
         params = locals_to_params(locals())
+        # Python is strict in which variables gets passed to methods. We get this
+        # value from the device descriptors, thats why we have to strip it out.
+        if "defaultBrowserType" in params:
+            del params["defaultBrowserType"]
         if viewport == 0:
             del params["viewport"]
             params["noDefaultViewport"] = True

playwright/sync_api.py

@@ -5592,6 +5592,7 @@ def newContext(
         hasTouch: bool = None,
         colorScheme: Literal["light", "dark", "no-preference"] = None,
         acceptDownloads: bool = None,
+        defaultBrowserType: str = None,
     ) -> "BrowserContext":
         """Browser.newContext
 
@@ -5657,6 +5658,7 @@ def newContext(
                     hasTouch=hasTouch,
                     colorScheme=colorScheme,
                     acceptDownloads=acceptDownloads,
+                    defaultBrowserType=defaultBrowserType,
                 )
             )
         )

tests/async/test_issues.py

@@ -7,3 +7,10 @@ async def test_issue_189(browser_type):
     page = await browser.newPage()
     assert await page.evaluate("1 + 1") == 2
     await browser.close()
+
+
+@pytest.mark.only_browser("chromium")
+async def test_issue_195(playwright, browser):
+    iphone_11 = playwright.devices["iPhone 11"]
+    context = await browser.newContext(**iphone_11)
+    await context.close()