When upgrading OMI, NoSSLv2, NoSSLV3, NoTLSv1_0 etc are overwritten

[timhe]

No description provided.

[JumpingYang001]

can you provide you upgraded which version to which version? thanks
We will try it today.

[JumpingYang001]

@timhe we have reproduced the issue, thanks for filing it! we will fix it, thanks.

[JumpingYang001]

@timhe, can you share your upgrade command?
as our test team tried, by default option is N as below, that means by default, the omiserver.conf will not be overwrote.

dpkg -i omi-1.6.0-0.ssl_100.ulinux.x86.deb 
(Reading database ... 30391 files and directories currently installed.)
Preparing to unpack omi-1.6.0-0.ssl_100.ulinux.x86.deb ...
Unconfiguring omid service ...
Unpacking omi (1.6.0.0) over (1.4.2.5) ...
Setting up omi (1.6.0.0) ...

Configuration file '/etc/opt/omi/conf/omiserver.conf'
==> Modified (by you or by a script) since installation.
==> Package distributor has shipped an updated version.
   What would you like to do about it ?  Your options are:
    Y or I  : install the package maintainer's version
    N or O  : keep your currently-installed version
      D     : show the differences between the versions
      Z     : start a shell to examine the situation
The default action is to keep your current version.
*** omiserver.conf (Y/I/N/O/D/Z) [default=N] ? 
************************************************************
* Warning: The certificate and keyfile were not generated  *
* since they already exist.                                *
************************************************************
2018-12-13 23:52:35 : Crontab no longer configured to update omi keytab.
2018-12-13 23:52:35 : Crontab configured to update omi keytab automatically
Configuring OMI service ...
Checking if cron is installed...
Checking if cron/crond service is started...
Set up a cron job to OMI logrotate every 15 minutes
Processing triggers for systemd (215-17) ...

[JumpingYang001]

Be overwrote scenarios: (only deb systems upgrade shows "confirm overwrite" message)
when press Y to overwrite for deb systems:
or just upgrade normal rpm systems:

1.OMI version from 1.4.2-5 upgrade to 1.5.0-0
2.OMI version from 1.4.2-5 upgrade to 1.6.0-0

Not be overwrote scenario: (No systems upgrade shows "confirm overwrite" message)

1.OMI version from 1.5.0-0 upgrade to 1.6.0-0

We only restore httpsport at current code: https://github.com/Microsoft/omi/blob/15f3f3a190b260fc14577b3c302bcef044650870/Unix/installbuilder/datafiles/Base_OMI.data#L430

[Infi-St]

my upgrade command was on CentOS 7, using rpm -U from 1.4.2-5 to 1.5.0-0

[JumpingYang001]

@timhe @Infi-St thanks for sharing it!