Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Add logic to limit the number of roles that can be enumerated for LivePresence #118

Closed
Stevenic opened this issue Oct 19, 2022 · 3 comments
Assignees
Labels

Comments

@Stevenic
Copy link
Contributor

Stevenic commented Oct 19, 2022

Describe your user scenario

Nothing prevents an app from trying to lookup roles for every member of a 1000 person meeting which would cause us to get throttled by Graph.

Describe the solution you'd like

Add logic to LivePresence to throttle the number of calls allowed by a client on a per/hour basis. The exact limits are TBD.

@Stevenic Stevenic self-assigned this Oct 19, 2022
@Stevenic
Copy link
Contributor Author

@ryanbliss do you have thoughts on throttle limits? I was thinking like 50 calls per session or something.

@ryanbliss
Copy link
Contributor

@Stevenic that is probably fine. Only problem is that having it hardcoded into the SDK means it is difficult to change without sdk upgrades, so it is harder to resolve live site issues that could result. Still probably better than nothing though.

Note: with the new presence proposal it is possible this will become obsolete.

@ryanbliss
Copy link
Contributor

Now obsolete with #516

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants