[0010] Update for writability was incomplete

[llvm-beanz]

Which proposal does this relate to?
Proposal 0010 - vk::BufferPointer

Describe the issue or outstanding question.
The Get() method definitions are missing non-const versions.

Additional context
See comment here

[greg-lunarg]

@llvm-beanz Please assign to me.

[greg-lunarg]

Here is the current spec:

template <struct S, int align>
class vk::BufferPointer {
    vk::BufferPointer(const vk::BufferPointer&);
    vk::BufferPointer& operator=(const vk::BufferPointer&);
    vk::BufferPointer(const uint64_t);
    S& Get() const;
}

Note that the const after Get() does not prevent writing of the pointee. The const here only assures that the BufferPointer itself is not changed by the Get() method.

So I contend that the current spec allows writing as well as reading of the pointee, and no change to the proposal is needed.

[llvm-beanz]

Apologies for incorrectly referencing the error. This is the incorrect line:

https://github.com/microsoft/hlsl-specs/blob/main/proposals/0010-vk-buffer-ref.md?plain=1#L71

The Get() method represents the struct const lvalue reference of the pointer to which it is applied.

The Get() method should not return a const lvalue reference (and doesn't in the code).

[greg-lunarg]

OK. I will remove const.

[greg-lunarg]

@llvm-beanz I believe this can now be closed. PTAL.