Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ExtensionsKHR.cpp to remove duplicated code from Serialize.cpp and Deserialize.cpp #32

Open
mebrunn opened this issue Mar 19, 2019 · 1 comment

Comments

@mebrunn
Copy link
Contributor

mebrunn commented Mar 19, 2019

The Parse* and Serializer* functions in ExtensionsKHR.cpp are copied from Serialize.cpp and Deserialize.cpp. That code should be shared rather than duplicated.

@vorlov-playrix
Copy link
Contributor

It becomes even worse when you try to add your own extension (de)serializer. You have to copy these functions to the new module in order to use them.

@bghgary bghgary added the triaged label Dec 7, 2023
@thomlucc thomlucc removed the triaged label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants