Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Pricing API calls via configuration #614

Open
giventocode opened this issue Feb 23, 2024 · 0 comments
Open

Disable Pricing API calls via configuration #614

giventocode opened this issue Feb 23, 2024 · 0 comments
Labels
TES Priority: P2 Groomed to a Priority 2 issue

Comments

@giventocode
Copy link
Contributor

Problem
When creating a list of available VM SKUs for a task, the TES server uses the Azure retail pricing API. If the API fails, a local list is used instead. However, when TES runs without public internet access, this behavior generates noise in network security appliances, monitoring logs, and firewalls.

Solution
Add a new setting to the TES server to disable the API call and always use the local list. The list must be constrained to the available SKUs of the Azure environment where TES is running (e.g. Azure or Azure Gov).

AC:

  • Add a new setting, EnableRetailPricingApi, set to True by default.
  • Create a new implementation of IBatchSkuInformationProvider that relies only on the local list and the Azure environment. Inject this implementation at boot time if EnableRetailPricingApi == False.
  • Add lists for different cloud environments or add the Azure environment as a column/property to the SKU list.
@giventocode giventocode added TES Priority: P1 Groomed to a Priority 1 issue TES Priority: P2 Groomed to a Priority 2 issue and removed TES Priority: P1 Groomed to a Priority 1 issue labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TES Priority: P2 Groomed to a Priority 2 issue
Projects
None yet
Development

No branches or pull requests

1 participant