Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ExecuteHttpRequestWithRetryAsync for (most) every http request #521

Open
BMurri opened this issue Nov 23, 2023 · 0 comments
Open

Use ExecuteHttpRequestWithRetryAsync for (most) every http request #521

BMurri opened this issue Nov 23, 2023 · 0 comments
Labels
enhancement New feature or request Performance Enable users can run task as cheap and as fast as possible Robustness Enable users can run tasks w/o bugs or with mitigation of known bugs TES Priority: P2 Groomed to a Priority 2 issue

Comments

@BMurri
Copy link
Collaborator

BMurri commented Nov 23, 2023

Problem:
I noticed during a recent transient failure of the unit-integration tests that most of the code is not using the http protocol-specific retry policy exposed through RetryHandler.ExecuteHttpRequestWithRetryAsync. Some code uses less efficient means, most code doesn't try at all.

Solution:
A lot of failures during runtime could be avoided without adding significant time (compared to the costs of retrying entire tasks) by using an efficient retry mechanism, especially one tuned to the metadata returned by the server in the HttpResponseMessage.

Describe alternatives you've considered
Leaving things as they are,

Code dependencies
Will this require code changes in:

  • CoA, for new and/or existing deployments? No
  • TES standalone, for new and/or existing deployments? No
  • Terra, for new and/or existing deployments? No
  • Build pipeline? No
  • Integration tests? No

Additional context
TBD

@BMurri BMurri added enhancement New feature or request Performance Enable users can run task as cheap and as fast as possible Robustness Enable users can run tasks w/o bugs or with mitigation of known bugs labels Nov 23, 2023
@MattMcL4475 MattMcL4475 added the TES Priority: P2 Groomed to a Priority 2 issue label Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Performance Enable users can run task as cheap and as fast as possible Robustness Enable users can run tasks w/o bugs or with mitigation of known bugs TES Priority: P2 Groomed to a Priority 2 issue
Projects
None yet
Development

No branches or pull requests

2 participants