Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TerraWsmClient configuration and instantiation to remove duplicate cache #441

Open
MattMcL4475 opened this issue Oct 3, 2023 · 0 comments
Open

Refactor TerraWsmClient configuration and instantiation to remove duplicate cache #441

MattMcL4475 opened this issue Oct 3, 2023 · 0 comments
Labels
bug Something isn't working Code Quality Improvements Make code make code more readable, maintainable, prevent bugs, improve security TES Priority: P3 Groomed to a Priority 3 issue up for grabs Available for community contributions. Please ask in the issue if you'd like to implement it
Milestone
TES Backlog

Comments

@MattMcL4475
Copy link
Collaborator

MattMcL4475 commented Oct 3, 2023 •
edited
Loading

TES' cache is created here:

ga4gh-tes/src/TesApi.Web/Startup.cs

Line 79 in cf39c62

.AddMemoryCache(o => o.ExpirationScanFrequency = TimeSpan.FromHours(12))

But TerraWsmApiClient creates another one:

ga4gh-tes/src/Tes.ApiClients/TerraWsmApiClient.cs

Line 22 in cf39c62

private static readonly IMemoryCache sharedMemoryCache = new MemoryCache(new MemoryCacheOptions());

Make any changes required so that there is only one instance of IMemoryCache
@MattMcL4475 MattMcL4475 added bug Something isn't working TES Priority: P3 Groomed to a Priority 3 issue labels Oct 3, 2023
@BMurri BMurri added up for grabs Available for community contributions. Please ask in the issue if you'd like to implement it Code Quality Improvements Make code make code more readable, maintainable, prevent bugs, improve security labels Feb 14, 2025
@BMurri BMurri added this to the TES Backlog milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Code Quality Improvements Make code make code more readable, maintainable, prevent bugs, improve security TES Priority: P3 Groomed to a Priority 3 issue up for grabs Available for community contributions. Please ask in the issue if you'd like to implement it
Projects
None yet
Milestone
TES Backlog
Development

No branches or pull requests
2 participants
@BMurri @MattMcL4475