Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motion component variant API doesn't support motion groups #32893

Open
robertpenner opened this issue Sep 23, 2024 · 1 comment
Open

Motion component variant API doesn't support motion groups #32893

robertpenner opened this issue Sep 23, 2024 · 1 comment
Assignees

Comments

@robertpenner
Copy link
Collaborator

  • Our createPresenceComponentVariant function assumes that enter and exit are each a single motion atom.
  • We need to support motion groups, where enter or exit can be an array of motion atoms.
  • Motion groups are essential for even simple choreography like a delayed collapse/expand:
    • enter by first expanding the height
    • Then fade in the content, using delay
    • The above are 2 motion atoms, grouped in a array and assigned to enter.
  • A variant of the delayed collapse could have different values of the delay, durations or easings.
  • A simpler approach with factory functions is possible.
@robertpenner robertpenner self-assigned this Sep 23, 2024
@robertpenner
Copy link
Collaborator Author

robertpenner commented Sep 23, 2024

I found a simpler functional approach that makes createPresenceComponentVariant unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant