From a0014f773d5a383bf13c3e13a88e6ae7cc078c79 Mon Sep 17 00:00:00 2001 From: Martin Hochel Date: Mon, 23 Sep 2024 19:33:56 +0200 Subject: [PATCH] fixup! fixup! ci: test win paths --- .github/workflows/check-tooling.yml | 2 +- .../src/generators/prepare-initial-release/index.spec.ts | 3 ++- .../src/generators/prepare-initial-release/index.ts | 3 +++ 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/check-tooling.yml b/.github/workflows/check-tooling.yml index 1024f2a8223ea..79bc345d65388 100644 --- a/.github/workflows/check-tooling.yml +++ b/.github/workflows/check-tooling.yml @@ -31,7 +31,7 @@ jobs: - run: yarn nx run scripts-executors:test -t start - # - run: yarn nx run workspace-plugin:test -t 'prepare-initial-release generator' + - run: yarn nx run workspace-plugin:test -t 'prepare-initial-release generator' - run: yarn nx list @fluentui/workspace-plugin diff --git a/tools/workspace-plugin/src/generators/prepare-initial-release/index.spec.ts b/tools/workspace-plugin/src/generators/prepare-initial-release/index.spec.ts index ae2ac592c920b..688a66989c27b 100644 --- a/tools/workspace-plugin/src/generators/prepare-initial-release/index.spec.ts +++ b/tools/workspace-plugin/src/generators/prepare-initial-release/index.spec.ts @@ -12,6 +12,7 @@ import { visitNotIgnoredFiles, } from '@nrwl/devkit'; import childProcess from 'child_process'; +import path from 'node:path'; import generator from './index'; import { PackageJson, TsConfig } from '../../types'; @@ -1064,7 +1065,7 @@ These are not production-ready components and **should never be used in product* const contents: Record = {}; visitNotIgnoredFiles(tree, root, file => { - contents[file] = stripIndents`${tree.read(file, 'utf-8')}` ?? ''; + contents[path.normalize(file)] = stripIndents`${tree.read(file, 'utf-8')}` ?? ''; }); return contents; diff --git a/tools/workspace-plugin/src/generators/prepare-initial-release/index.ts b/tools/workspace-plugin/src/generators/prepare-initial-release/index.ts index b474a12857bbc..36775da249088 100644 --- a/tools/workspace-plugin/src/generators/prepare-initial-release/index.ts +++ b/tools/workspace-plugin/src/generators/prepare-initial-release/index.ts @@ -156,12 +156,15 @@ async function stableRelease(tree: Tree, options: NormalizedSchema & { isSplitPr const bundleSizeFixturesRoot = joinPathFragments(options.projectConfig.root, 'bundle-size'); if (tree.exists(bundleSizeFixturesRoot)) { + console.log('===BUNDLE SIZE UPDATES====', { bundleSizeFixturesRoot }); visitNotIgnoredFiles(tree, bundleSizeFixturesRoot, filePath => { updateFileContent(tree, { filePath, updater: contentNameUpdater, }); }); + } else { + console.warn('=== NO BUNDLE SIZE UPDATES! ====', { bundleSizeFixturesRoot }); } const mdFilePath = {