-
Notifications
You must be signed in to change notification settings - Fork 31
Add support of Script.setScriptSource #5
Comments
Quoting @andysterland from #16
Does this mean the following scenario will not work?
This is somewhat key to the feature being useful, otherwise you'll get unreachable code in that it will have closures you cannot reach and missing captures. |
@caspervonb you are correct. Though with any live editing scenario, at a breakpoint or not, you can always get into a state that is nothing like would happen if the edit was applied and the page reloaded. Specifically changing the code doesn't' change the DOM nor does it reverse any affect the code had. Say, if you had a global function named But, you are very right the really useful scenario is when you hit an exception, spot the typo, change it and then set the statement (set statement is awesome!) back one and continue. Alas, it's just not supported in Chakra right now :(. |
I was referring to an explicit case in my use case, which is basically rewrite scripts as they are parsed to inject instrumentation) So to be clear, Chakra's edit and continue feature, cannot actually do edit and continue? What can it do then? |
Chakra has edit on idle. Not edit and continue. They are working on having edit and continue but it requires a large refactor on their side to make it work. |
So basically it takes effect on the next call rather than the current call stack? |
@caspervonb exactly. The edit itself won't be carried out till the engine goes back to idle, that is the current stack finishes executing. |
Fix event load/unload and add main property to package.json
Add support of setScriptSource, to enable projects like https://github.com/amokjs/amok to work with Edge.
The text was updated successfully, but these errors were encountered: