Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes name references after rename #410

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Fixes name references after rename #410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dev-proxy/ProxyCommandHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public async Task<int> InvokeAsync(InvocationContext context) {

var newReleaseInfo = await UpdateNotification.CheckForNewVersion();
if (newReleaseInfo != null) {
_logger.LogError($"New version {newReleaseInfo.Version} of the Graph Developer Proxy is available.");
_logger.LogError($"New Dev Proxy version {newReleaseInfo.Version} is available.");
_logger.LogError($"See https://aka.ms/devproxy/upgrade for more information.");
_logger.LogError(string.Empty);
}
Expand All @@ -93,7 +93,7 @@ public async Task<int> InvokeAsync(InvocationContext context) {
return 0;
}
catch (Exception ex) {
_logger.LogError("An error occurred while running the Developer Proxy");
_logger.LogError("An error occurred while running Dev Proxy");
_logger.LogError(ex.Message.ToString());
_logger.LogError(ex.StackTrace?.ToString() ?? string.Empty);
var inner = ex.InnerException;
Expand Down
10 changes: 5 additions & 5 deletions specs/recording-requests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Record request logging

Record request logging allows Developer Proxy to capture request logging activities that occurred while the proxy was in record mode. The captured request logging items are passed for further processing to the Developer Proxy plugins. This feature is foundational for scenarios such as permission analysis, building tailored SDKs, audit reports, etc.
Record request logging allows Dev Proxy to capture request logging activities that occurred while the proxy was in record mode. The captured request logging items are passed for further processing to the Dev Proxy plugins. This feature is foundational for scenarios such as permission analysis, building tailored SDKs, audit reports, etc.

## History

Expand All @@ -10,12 +10,12 @@ Record request logging allows Developer Proxy to capture request logging activit

## Implementation

Developer Proxy can be put in recording mode either by using the `--record` command line option or by pressing `r` after starting the proxy. Recording can be stopped by pressing `s` while running the proxy or by closing the proxy using `CTRL+C`. While recording is stopped and the proxy is running, users can start a new recording session by pressing `r` again.
Dev Proxy can be put in recording mode either by using the `--record` command line option or by pressing `r` after starting the proxy. Recording can be stopped by pressing `s` while running the proxy or by closing the proxy using `CTRL+C`. While recording is stopped and the proxy is running, users can start a new recording session by pressing `r` again.

While recording, Developer Proxy will show an indicator in the terminal window. The indicator will be displayed in the top right corner of the window and will be hidden if the proxy is not recording.
While recording, Dev Proxy will show an indicator in the terminal window. The indicator will be displayed in the top right corner of the window and will be hidden if the proxy is not recording.

Proxy is recording requests by subscribing to a `RequestLogged` event which is raised each time proxy logged a request-related log message. The event contains information about the logged message.

After the recording is stopped, Developer Proxy will raise the `RecordingStopped` event. Plugins can subscribe to this event to process the captured requests.
After the recording is stopped, Dev Proxy will raise the `RecordingStopped` event. Plugins can subscribe to this event to process the captured requests.

Recording is a core feature of Developer Proxy and will be implemented in the main proxy code.
Recording is a core feature of Dev Proxy and will be implemented in the main proxy code.
Loading