Skip to content

Commit 76ba9c3

Browse files
committed
Resolve PR comments
1 parent 048153c commit 76ba9c3

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

dev-proxy/Logging/ProxyConsoleFormatter.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,9 @@ private void LogRequest(RequestLog requestLog, string category, IExternalScopePr
4848

4949
// don't log intercepted response to console
5050
if (messageType == MessageType.InterceptedResponse ||
51-
(messageType == MessageType.Skipped && !_options.ShowSkipMessages))
51+
(messageType == MessageType.Skipped && !_options.ShowSkipMessages) ||
52+
(messageType == MessageType.Timestamp && !_options.ShowTimestamps)
53+
)
5254
{
5355
return;
5456
}

dev-proxy/Logging/ProxyConsoleFormatterOptions.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,5 +9,5 @@ public class ProxyConsoleFormatterOptions: ConsoleFormatterOptions
99
{
1010
public bool ShowSkipMessages { get; set; } = true;
1111

12-
public bool ShowTimestamps { get; set; } = false;
12+
public bool ShowTimestamps { get; set; } = true;
1313
}

dev-proxy/ProxyEngine.cs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -475,16 +475,13 @@ async Task OnRequestAsync(object sender, SessionEventArgs e)
475475
await e.GetRequestBodyAsString();
476476
}
477477

478-
using var scope = _logger?.BeginScope(e.HttpClient.Request.Method ?? "", e.HttpClient.Request.Url, e.GetHashCode());
478+
using var scope = _logger.BeginScope(e.HttpClient.Request.Method ?? "", e.HttpClient.Request.Url, e.GetHashCode());
479479

480480
e.UserData = e.HttpClient.Request;
481481

482-
_logger?.LogRequest($"{e.HttpClient.Request.Method} {e.HttpClient.Request.Url}", MessageType.InterceptedRequest, new LoggingContext(e));
482+
_logger.LogRequest($"{e.HttpClient.Request.Method} {e.HttpClient.Request.Url}", MessageType.InterceptedRequest, new LoggingContext(e));
483483

484-
if (_config.ShowTimestamps)
485-
{
486-
_logger?.LogRequest($"{DateTimeOffset.UtcNow}", MessageType.Timestamp, new LoggingContext(e));
487-
}
484+
_logger.LogRequest($"{DateTimeOffset.UtcNow}", MessageType.Timestamp, new LoggingContext(e));
488485

489486
await HandleRequestAsync(e, proxyRequestArgs);
490487
}

0 commit comments

Comments
 (0)