-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to builtin authentication provider & remove Configure Pipeline support #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VS Code 1.82/Node 18 supports all the way up to ES2022.
winstliu
force-pushed
the
use-vscode-authentication
branch
from
September 16, 2024 01:02
4873fe4
to
69da0d1
Compare
And use clearSessionPreference when the wrong account is used
kirill-ivlev
approved these changes
Sep 19, 2024
vmapetr
approved these changes
Sep 20, 2024
DergachevE
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Azure Accounts being deprecated in January, this change migrates the Azure Pipelines extension to instead use VS Code's builtin "Microsoft" authentication provider.
The Configure Pipeline feature relied heavily on Azure Accounts. Instead of migrating it, I've made the decision to remove the feature for the following reasons.
Combined with the amount of changes necessary to make it support VS Code authentication, in my mind the benefits it provides no longer outweighs the high maintenance cost it brings. In the future, I would be open to adding back portions of the functionality (such as service connection creation) but for now the easiest way forward is a complete removal.
I tested the authentication changes on both a MSA and work account and confirmed that I was still able to authenticate and view all my ADO organizations.
Fixes #590
Fixes #583
Fixes #582
Fixes #581
Fixes #580
Fixes #579
Fixes #538
Closes #542
Closes #509
Closes #436
Closes #576