Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to builtin authentication provider & remove Configure Pipeline support #595

Merged
merged 15 commits into from
Oct 1, 2024

Conversation

winstliu
Copy link
Member

@winstliu winstliu commented Sep 15, 2024

With Azure Accounts being deprecated in January, this change migrates the Azure Pipelines extension to instead use VS Code's builtin "Microsoft" authentication provider.

The Configure Pipeline feature relied heavily on Azure Accounts. Instead of migrating it, I've made the decision to remove the feature for the following reasons.

  • Unmaintained: Since getting merged, this feature has seen very little investment.
  • Out of date: Many of the templates the feature provides are considerably out-of-date, for example installing Node 10.
  • Not following best practices: The extension tries to create a service connection backed with a client credential rather than WIF.
  • Large file size: This feature took up roughly 75% of the total extension size on disk.

Combined with the amount of changes necessary to make it support VS Code authentication, in my mind the benefits it provides no longer outweighs the high maintenance cost it brings. In the future, I would be open to adding back portions of the functionality (such as service connection creation) but for now the easiest way forward is a complete removal.

I tested the authentication changes on both a MSA and work account and confirmed that I was still able to authenticate and view all my ADO organizations.

Fixes #590
Fixes #583
Fixes #582
Fixes #581
Fixes #580
Fixes #579
Fixes #538
Closes #542
Closes #509
Closes #436
Closes #576

@winstliu winstliu requested review from a team as code owners September 15, 2024 22:43
@winstliu winstliu enabled auto-merge (squash) October 1, 2024 14:57
@winstliu winstliu merged commit 6c788db into main Oct 1, 2024
3 of 4 checks passed
@winstliu winstliu deleted the use-vscode-authentication branch October 1, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment