Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resetting Reviewer vote to 0 via GitAPI has no effect #611

Open
tommywilkinson opened this issue Oct 3, 2024 · 1 comment
Open

Resetting Reviewer vote to 0 via GitAPI has no effect #611

tommywilkinson opened this issue Oct 3, 2024 · 1 comment

Comments

@tommywilkinson
Copy link
Member

Environment

Node version: 18.15.0
Npm version: 9.5.0
OS and version: both windows 11 (current) and linux (ubuntu current LTS)
azure-devops-node-api version: 10.2.2

Issue Description

Updating reviewer vote has no effect via node API.

Expected behavior

Updating a reviewer vote to 0 should reset the vote in the pull request for a given reviewer.

Actual behavior

No effect on reviewer vote status after performing vote reset REST call.

Steps to reproduce

  1. Create an ADO PR
  2. Have an "Approved" reviewer in that PR
  3. Use rest API to attempt to update that reviewer's vote to 0, using updatePullRequestReviewer
  4. Observer that REST call completes successfully, but vote status will not have been reset (will still be "Approved")

Logs

Can provide MSFT internal pipeline agent logs upon request.

@ismayilov-ismayil
Copy link

Hi @tommywilkinson, thanks for reporting! We are working on more prioritized issues at the moment, but will get back to this one soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants