Ignore allocations inside Debug.Assert

[benaadams]

As they are removed in release mode.

e.g. from SqlDataReader

Debug.Assert(SniContext.Snix_Read == stateObj.SniContext, string.Format((IFormatProvider)null, "The SniContext should be Snix_Read but it actually is {0}", stateObj.SniContext));

Produces

HAA0601	Value type to reference type conversion causes boxing at call site (here), and unboxing at the callee-site. Consider using generics if applicable

[edespong]

If we want to generalize it, anything marked with attribute [System.Diagnostics.Conditional("DEBUG")] should be ignored.

To solve this, my feeling is that it is needed to check every type of allocation, check if any of its parent syntax nodes is a InvocationExpression (or cannot possible have a parent who is) and then check its attributes or against a known list (e.g. "System.Diagnostics.Debug.Assert").

[mjsabby]

@edespong yeah. We do a lot of similar walks, so I don't think it should be that big of a perf hit.