[EN Units] 1.6m isn't recognized (Python) #1519 (#1753)

microsoft · Jul 30, 2019 · f994e17 · f994e17
1 parent 5b50274
commit f994e17
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/Python/libraries/recognizers-number/recognizers_number/number/english/extractors.py b/Python/libraries/recognizers-number/recognizers_number/number/english/extractors.py
@@ -143,7 +143,7 @@ def __init__(self, placeholder):
                 val='DoubleNum'),
             ReVal(
                 re=RegExpUtility.get_safe_reg_exp(
-                    EnglishNumeric.DoubleWithMultiplierRegex),
+                    EnglishNumeric.DoubleWithMultiplierRegex, regex.S),
                 val='DoubleNum'),
             ReVal(
                 re=RegExpUtility.get_safe_reg_exp(

diff --git a/Specs/NumberWithUnit/English/DimensionModel.json b/Specs/NumberWithUnit/English/DimensionModel.json
@@ -814,5 +814,24 @@
     "Input": "I ' m tired",
     "NotSupported": "javascript, python, java",
     "Results": []
+  },
+  {
+    "Input": "I'm 1.8m tall.",
+    "Results": [
+      {
+        "Text": "1.8m",
+        "Start": 4,
+        "End": 7,
+        "TypeName": "dimension",
+        "Resolution": {
+          "unit": "Meter",
+          "value": "1.8"
+        }
+      }
+    ]
+  },
+  {
+    "Input": "It cost 1.8M dollars.",
+    "Results": []
   }
 ]