Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpatched Multi-Column TopK #19

Open
danxuZhang opened this issue Oct 17, 2024 · 0 comments
Open

Unpatched Multi-Column TopK #19

danxuZhang opened this issue Oct 17, 2024 · 0 comments

Comments

@danxuZhang
Copy link

According to scripts/patch.sh, it has applied Postgres.patch, but doesn't apply new_pg.patch.

CURRENT_PATH=$(dirname "$0")
SPTAG_PATH="${CURRENT_PATH}/../thirdparty/SPTAG"
(cd $SPTAG_PATH && git apply ../../patch/spann.patch)
HNSW_PATH="${CURRENT_PATH}/../thirdparty/hnsw"
(cd $HNSW_PATH && git apply ../../patch/hnsw.patch)
POSTGRES_PATH="${CURRENT_PATH}/../thirdparty/Postgres"
(cd $POSTGRES_PATH && git apply ../../patch/Postgres.patch)

In new_pg.patchline 306, it called multicol_topk() for multi-column search in PostgresMain.

+                strcpy(result, "select * from multicol_topk('");

However, in Postgres.patch line 438,topk()is called but not multicol_topk() in PostgresMain.

+						strcpy(result, "select topk('");
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant