Skip to content

Unpatched Multi-Column TopK #19

Open
@cache-roaster

Description

@cache-roaster

According to scripts/patch.sh, it has applied Postgres.patch, but doesn't apply new_pg.patch.

CURRENT_PATH=$(dirname "$0")
SPTAG_PATH="${CURRENT_PATH}/../thirdparty/SPTAG"
(cd $SPTAG_PATH && git apply ../../patch/spann.patch)
HNSW_PATH="${CURRENT_PATH}/../thirdparty/hnsw"
(cd $HNSW_PATH && git apply ../../patch/hnsw.patch)
POSTGRES_PATH="${CURRENT_PATH}/../thirdparty/Postgres"
(cd $POSTGRES_PATH && git apply ../../patch/Postgres.patch)

In new_pg.patchline 306, it called multicol_topk() for multi-column search in PostgresMain.

+                strcpy(result, "select * from multicol_topk('");

However, in Postgres.patch line 438,topk()is called but not multicol_topk() in PostgresMain.

+						strcpy(result, "select topk('");

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions