Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules extension names reported in the HTML are stripping strings enclosed in <>, e.g. <dn>,<object-id> #23

Open
Bob-Bradley opened this issue Aug 22, 2024 · 1 comment

Comments

@Bob-Bradley
Copy link

Bob-Bradley commented Aug 22, 2024

Where rules-extension style advanced flow rule names include selected attributes enclosed in <> (e.g. ,, etc.) these are being stripped from the Attribute Flows table in the HTML report (Mapping Type column).

e.g. a VB rules extension file might have the following code under the MapAttributesForImport mapping to the advanced flow rule cd.user:<dn>->mv.person:domain:

Select Case FlowRuleName
Case "cd.user:<dn>->mv.person:domain"
...

However, in the HTML report this will appear (incorrectly) as the following Attribute Flow:

Rules Extension - cd.user:->mv.person:domain

The downside of the report doing this is that searches of the code base for the above Rules Extension name will return no matches.

@Bob-Bradley
Copy link
Author

Bob-Bradley commented Aug 22, 2024

I just realised that in the act of writing up the issue above, I discovered that the same happens with the markdown text ... I could only get my text appearing correctly by HTML-escaping the < and >

I can also confirm that in the raw HTML I can see the problematic (unescaped) text is present in the td innerHtml ... so this is simply a rendering issue where we there should be an HTMLEncode applied to such strings to ensure they are rendered correctly (visually) in the browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant