Skip to content

Commit a6f0ac0

Browse files
committed
add comment about potential race condition
1 parent 6f958d5 commit a6f0ac0

File tree

1 file changed

+3
-0
lines changed
  • src/MICore/CommandFactories

1 file changed

+3
-0
lines changed

src/MICore/CommandFactories/gdb.cs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -186,6 +186,9 @@ public override async Task<List<ulong>> StartAddressesForLine(string file, uint
186186
private async Task JumpInternal(string target)
187187
{
188188
// temporary breakpoint + jump
189+
// NB: the gdb docs state: "Resume execution at line linespec. Execution stops again immediately if there is a breakpoint there."
190+
// We rely on this. If another thread hits a breakpoint before that we have a UX problem
191+
// and would need to handle this via scheduler-locking for all-stop mode and ??? for non-stop mode.
189192
await _debugger.CmdAsync("-break-insert -t " + target, ResultClass.done);
190193
await _debugger.CmdAsync("-exec-jump " + target, ResultClass.running);
191194
}

0 commit comments

Comments
 (0)