Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__LIB_LIGHTGBM_FILENAME fix #6775

Closed
wants to merge 1 commit into from
Closed

Conversation

montanalow
Copy link

__LIB_LIGHTGBM_FILENAME doesn't exist BUILD_STATIC_LIB is true, so this custom command should be skipped.

__LIB_LIGHTGBM_FILENAME doesn't exist BUILD_STATIC_LIB is true, so this custom command should be skipped.
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your interest in LightGBM, but I don't understand this patch.

Can you please provide a description including:

  • the version / commit hash of LightGBM you're building against
  • the exact commands you ran
  • logs (including the error message) showing the output you got
  • details about your environment (operating system? compiler?)

The code you're editing is already inside a block that will not run if BUILD_STATIC_LIB=ON:

if(APPLE AND USE_OPENMP AND NOT BUILD_STATIC_LIB)

I strongly suspect that you might be building from a version of LightGBM that does not contain this fix: #6600

@montanalow
Copy link
Author

Thanks for pointing out the existing patch/fix. I was indeed building with a version (v4.5.0) that did not include it. I'll move my dependency to the master branch until a new release includes that check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants