Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move benchmarks to run docker containers #141

Open
jeffa5 opened this issue Oct 31, 2022 · 1 comment
Open

Move benchmarks to run docker containers #141

jeffa5 opened this issue Oct 31, 2022 · 1 comment
Labels
benchmark Work on the benchmarking enhancement New feature or request

Comments

@jeffa5
Copy link
Collaborator

jeffa5 commented Oct 31, 2022

Is your feature request related to a problem? Please describe.

Currently the benchmarks run the binaries themselves, this is ok for developers as they will have all of the dependencies already available and should be able to build the artifacts. However, for increased reproducibility I think it would be better to have the benchmarks run in containers. This standardises the version and we can publish tagged images from GH releases.

Describe the solution you'd like

The benchmarks run the nodes in docker containers rather than using the local enclave objects.

Describe alternatives you've considered

Continuing running as is, see above.
@jeffa5 jeffa5 added enhancement New feature or request benchmark Work on the benchmarking labels Oct 31, 2022
@jeffa5
Copy link
Collaborator Author

jeffa5 commented Nov 9, 2022

Completed for lskv nodes, not yet for etcd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
benchmark Work on the benchmarking enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeffa5