Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NSPanel #189

Open
vancura opened this issue Apr 13, 2020 · 3 comments
Open

NSPanel #189

vancura opened this issue Apr 13, 2020 · 3 comments
Labels
Components Components that need to be implemented or added to the Figma library Enhancement Low priority request that would be nice to have but isn't critical
Milestone
0.8.5 – ✨ Improve...

Comments

@vancura
Copy link

vancura commented Apr 13, 2020

The panel component generates a lot of boilerplate, as it tries to replicate everything what's in the Figma document. Instead, it should parse and render similarly to the NSWindow component.

Standard window:

image

Currently parsed panel:

image
@hbons
Copy link
Member

hbons commented Apr 13, 2020

I think this is because the panel component is not yet treated as a control.

@hbons hbons added the Components Components that need to be implemented or added to the Figma library label Apr 13, 2020
@hbons hbons added this to the ✨ 1.1 – Improvement updates milestone Apr 13, 2020
@hbons hbons added the Enhancement Low priority request that would be nice to have but isn't critical label Apr 28, 2020
@hbons
Copy link
Member

hbons commented Apr 28, 2020

We're not really using Panels right now, so this is low priority.

@hbons hbons changed the title AppKit: Panel component generates a lot of boilerplate NSPanel May 6, 2020
@hbons hbons removed this from the ✨ 1.1 – Improvement updates milestone May 15, 2020
@netonjm
Copy link
Member

netonjm commented Jul 3, 2020 •
edited
Loading

@vancura, it happens because this control is not created yet, then it renders as a normal layer and sublayers. Which makes me think that there is no task assigned for the NSPanel?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Components Components that need to be implemented or added to the Figma library Enhancement Low priority request that would be nice to have but isn't critical
Projects
None yet
Milestone
0.8.5 – ✨ Improvement updates
Development

No branches or pull requests
3 participants
@vancura @hbons @netonjm