Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#3114 Format AppId without brackets and lowercase for VsCode Integration #3137

Merged
merged 5 commits into from
Mar 4, 2025
Merged

#3114 Format AppId without brackets and lowercase for VsCode Integration #3137

merged 5 commits into from
Mar 4, 2025

Conversation

BB97GER
Copy link
Contributor

@BB97GER BB97GER commented Mar 3, 2025 •
edited by github-actions bot
Loading

Summary

Work Item(s)

Fixes #3114

Fixes AB#567859

@BB97GER BB97GER requested a review from a team as a code owner March 3, 2025 13:00
@github-actions github-actions bot added AL: System Application From Fork Pull request is coming from a fork labels Mar 3, 2025
JesperSchulz
JesperSchulz previously approved these changes Mar 3, 2025
View reviewed changes
@JesperSchulz JesperSchulz added Linked Issue is linked to a Azure Boards work item Integration GitHub request for Integration area labels Mar 3, 2025
@github-actions github-actions bot added this to the Version 27.0 milestone Mar 3, 2025
@BB97GER
Copy link
Contributor Author

BB97GER commented Mar 3, 2025 •
edited
Loading

I had forgotten to adjust the test. It has now been added.
The VsCode Ext. "ms-dynamics-smb.al" can also work with a lowercase appId.
vscode://ms-dynamics-smb.al/navigateTo?type=page&id=0&name=&appid=&server=http%3A%2F%2Fbcserver&serverInstance=BC&port=7049&authentication=UserPassword&runtime=15.0&appVersion=27.0.30807.0&sessionId=80&dependencies=a15fd72b-6430-4bb6-dfbc-1a948b7b15b4%2CMyApp2%2CPublisher2%2C23.0.0.0%3Bf15fd82b-8050-4bb6-bfbc-1a948b7b17c3%2CMyApp1%2CPublisher1%2C1.2.3.4%3B ->
image

@JesperSchulz
Copy link
Contributor

Before merging, let's get someone from Developer Tools to also look at this. @SBalslev, would you be able to take a quick look?

@JesperSchulz JesperSchulz merged commit 5238a6b into microsoft:main Mar 4, 2025
22 checks passed
@BB97GER BB97GER deleted the B97GER-Issue#3114 branch March 5, 2025 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesperSchulz JesperSchulz JesperSchulz approved these changes

@blrobl blrobl blrobl approved these changes

Assignees
No one assigned
Labels
AL: System Application From Fork Pull request is coming from a fork Integration GitHub request for Integration area Linked Issue is linked to a Azure Boards work item
Projects
None yet
Milestone
Version 27.0
Development

Successfully merging this pull request may close these issues.

[Bug]: VsCodeIntegration create AppId Dependencie with Brackets
3 participants
@BB97GER @JesperSchulz @blrobl