Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported Languages #2463

Merged

Conversation

kasperdj
Copy link
Contributor

@kasperdj kasperdj commented Dec 5, 2024

Summary

A new cross-company table called Supported Language has been added. It is possible to define a list of Application Languages in this table. If one or more languages have been defined in this table, then the lookup page "Available Languages" which is used in "My Settings" and "User Settings" will be filtered to only show the languages defined in Supported Language. So if a super user has configured a number of Supported Languages, then this will impact which Application Languages the user can select from.

Documentation attached.
Suported Languages functionality.docx

Note: as I have not been assigned object id's, the new objects have been assigned in the 5010x range

Work Item(s)

Fixes #2465
Fixes AB#549461

@kasperdj kasperdj requested review from a team as code owners December 5, 2024 10:23
@github-actions github-actions bot added AL: System Application From Fork Pull request is coming from a fork labels Dec 5, 2024
@kasperdj
Copy link
Contributor Author

kasperdj commented Dec 5, 2024

@microsoft-github-policy-service agree [company="Elbek & Vejrup A/S"]

@kasperdj
Copy link
Contributor Author

kasperdj commented Dec 5, 2024

@microsoft-github-policy-service agree
@microsoft-github-policy-service agree [company="Elbek & Vejrup A/S"]

@kasperdj
Copy link
Contributor Author

kasperdj commented Dec 5, 2024

@sorenfriisalexandersen or @darjoo I have the requested changes ready locally but will await pushing the changes before I get feedback from Microsoft on:

What should the Fixed # refererence be on this PR as original Issue No is apparently not the correct one - see: https://github.com/microsoft/BusinessCentralApps/issues/1061#issuecomment-2519896200

@microsoft microsoft deleted a comment from github-actions bot Dec 5, 2024
@microsoft microsoft deleted a comment from github-actions bot Dec 5, 2024
@microsoft microsoft deleted a comment from github-actions bot Dec 5, 2024
@github-actions github-actions bot added the Linked Issue is linked to a Azure Boards work item label Dec 5, 2024
@github-actions github-actions bot added this to the Version 26.0 milestone Dec 5, 2024
@JesperSchulz
Copy link
Contributor

@kasperdj, we're all set. Please go ahead and push your changes 🥳

@kasperdj
Copy link
Contributor Author

kasperdj commented Dec 5, 2024

@sorenfriisalexandersen before I push the requested changes I have one additional question for you. Do you want this implementation of Allowed Languages to also impact the Region selection in the same way as currently made for the application language?

@sorenfriisalexandersen
Copy link

@sorenfriisalexandersen before I push the requested changes I have one additional question for you. Do you want this implementation of Allowed Languages to also impact the Region selection in the same way as currently made for the application language?

@kasperdj it should, yes. Good catch.

@JesperSchulz
Copy link
Contributor

Let's give this a spin!

@kasperdj
Copy link
Contributor Author

kasperdj commented Dec 5, 2024

Updated UI documentation attached after renaming the functionality to "Allowed Languages" and also supporting Region filtering. Allowed Languages functionality.docx

darjoo
darjoo previously approved these changes Dec 5, 2024
Copy link
Contributor

@darjoo darjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff, but all good otherwise.

darjoo
darjoo previously approved these changes Dec 5, 2024
@kasperdj
Copy link
Contributor Author

kasperdj commented Dec 5, 2024

@darjoo will you please take action on the build issue with the Object No. you assigned to me not being allowed?

See last run: https://github.com/microsoft/BCApps/actions/runs/12181966230 - I would prefer not to mess with Microsofts app.json and settings.json files

@JesperSchulz
Copy link
Contributor

JesperSchulz commented Dec 5, 2024

@darjoo will you please take action on the build issue with the Object No. you assigned to me not being allowed?

See last run: https://github.com/microsoft/BCApps/actions/runs/12181966230 - I would prefer not to mess with Microsofts app.json and settings.json files

@kasperdj, you simply need to add the ID to the app.json of your module: src/System Application/App/Language/app.json. That should do! I don't think we have right to change the code in your fork - unless you grant us :-)

@JesperSchulz
Copy link
Contributor

And we're all green! Let's ship this 🥳

@JesperSchulz JesperSchulz dismissed sorenfriisalexandersen’s stale review December 6, 2024 09:03

Sørens issues were addressed.

@JesperSchulz JesperSchulz merged commit af514de into microsoft:main Dec 6, 2024
24 checks passed
@kasperdj kasperdj deleted the features/SupportLanguages-kasperdj branch December 9, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AL: System Application From Fork Pull request is coming from a fork Linked Issue is linked to a Azure Boards work item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BC Idea]: Limit the number of available languages in the web client
4 participants