-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supported Languages #2463
Supported Languages #2463
Conversation
@microsoft-github-policy-service agree [company="Elbek & Vejrup A/S"] |
src/System Application/App/Language/src/SupportedLanguages.Page.al
Outdated
Show resolved
Hide resolved
src/System Application/App/Language/src/SupportedLanguages.Page.al
Outdated
Show resolved
Hide resolved
@microsoft-github-policy-service agree |
src/System Application/App/Language/permissions/LanguageEdit.PermissionSet.al
Outdated
Show resolved
Hide resolved
src/System Application/App/Language/src/LanguageImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
src/System Application/App/Language/src/LanguageImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
src/System Application/App/Language/src/LanguageImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
src/System Application/App/Language/src/SupportedLanguage.Table.al
Outdated
Show resolved
Hide resolved
src/System Application/App/Language/src/SupportedLanguages.Page.al
Outdated
Show resolved
Hide resolved
src/System Application/App/Language/src/SupportedLanguages.Page.al
Outdated
Show resolved
Hide resolved
@sorenfriisalexandersen or @darjoo I have the requested changes ready locally but will await pushing the changes before I get feedback from Microsoft on: What should the Fixed # refererence be on this PR as original Issue No is apparently not the correct one - see: https://github.com/microsoft/BusinessCentralApps/issues/1061#issuecomment-2519896200 |
@kasperdj, we're all set. Please go ahead and push your changes 🥳 |
@sorenfriisalexandersen before I push the requested changes I have one additional question for you. Do you want this implementation of Allowed Languages to also impact the Region selection in the same way as currently made for the application language? |
@kasperdj it should, yes. Good catch. |
Let's give this a spin! |
Updated UI documentation attached after renaming the functionality to "Allowed Languages" and also supporting Region filtering. Allowed Languages functionality.docx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor stuff, but all good otherwise.
src/System Application/App/Language/src/LanguageImpl.Codeunit.al
Outdated
Show resolved
Hide resolved
src/System Application/App/Language/permissions/LanguageObjects.PermissionSet.al
Outdated
Show resolved
Hide resolved
src/System Application/App/Language/permissions/LanguageEdit.PermissionSet.al
Outdated
Show resolved
Hide resolved
@darjoo will you please take action on the build issue with the Object No. you assigned to me not being allowed? See last run: https://github.com/microsoft/BCApps/actions/runs/12181966230 - I would prefer not to mess with Microsofts app.json and settings.json files |
@kasperdj, you simply need to add the ID to the app.json of your module: src/System Application/App/Language/app.json. That should do! I don't think we have right to change the code in your fork - unless you grant us :-) |
And we're all green! Let's ship this 🥳 |
Sørens issues were addressed.
Summary
A new cross-company table called Supported Language has been added. It is possible to define a list of Application Languages in this table. If one or more languages have been defined in this table, then the lookup page "Available Languages" which is used in "My Settings" and "User Settings" will be filtered to only show the languages defined in Supported Language. So if a super user has configured a number of Supported Languages, then this will impact which Application Languages the user can select from.
Documentation attached.
Suported Languages functionality.docx
Note: as I have not been assigned object id's, the new objects have been assigned in the 5010x range
Work Item(s)
Fixes #2465
Fixes AB#549461