Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Post+Print warehouseshipment is printing ALL shipmentheaders in the database! #2323

Closed
1 task
Pieterheinevdm opened this issue Nov 8, 2024 · 3 comments
Labels
Bug Something isn't working

Comments

@Pieterheinevdm
Copy link
Contributor

Pieterheinevdm commented Nov 8, 2024

Describe the issue

Post+Print warehouseshipment is printing ALL shipmentheaders in the database!

problem:
codeunit 5746 "Sales Whse. Post Shipment" procedure PrintDocuments
at minimum a SalesShipmentHeader.MarkedOnly(true)

        if DocumentEntryToPrint.FindSet() then
            repeat
                SalesShipmentHeader.Get(DocumentEntryToPrint."Document No.");
                SalesShipmentHeader.Mark(true);
            until DocumentEntryToPrint.Next() = 0;
        SalesShipmentHeader.MarkedOnly(true); //NEW
        SalesShipmentHeader.PrintRecords(false);

Apply same fix for sales invoices 10lines before this line in same procedure

Expected behavior

Only print the now posted "Sales Shipment Headers" (and Sales Invoice Headers)

Steps to reproduce

Post+Print warehouseshipment

Additional context

No response

I will provide a fix for a bug

  • I will provide a fix for a bug
@Pieterheinevdm Pieterheinevdm added the Bug Something isn't working label Nov 8, 2024
@pmohanakrishna
Copy link
Contributor

Do you mean this?

If yes then it is already there.

Image

@Pieterheinevdm
Copy link
Contributor Author

Pieterheinevdm commented Nov 8, 2024

issue moved to: https://github.com/microsoft/ALAppExtensions #27605

@Pieterheinevdm
Copy link
Contributor Author

Do you mean this?

If yes then it is already there.

Image

No is not fixed!
Mark(true) is not doing any filtering, this is done bij de MarkedOnly(true) command.
So a developer still needs to add a MarkedOnly(true).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants