Skip to content
This repository has been archived by the owner on Jul 8, 2024. It is now read-only.

Make LSTM more LSTM-like #143

Open
tomjaguarpaw opened this issue Oct 24, 2019 · 1 comment
Open

Make LSTM more LSTM-like #143

tomjaguarpaw opened this issue Oct 24, 2019 · 1 comment
Assignees
@awf
Labels
enhancement

Comments

@tomjaguarpaw
Copy link
Collaborator

LSTM logsumexp has 2 added to the sum. Do we know why this is? The earliest occurrence I can see is d75f713#diff-cadabfe323e7f3ac5fe22b5de628d2aeR24
@awf awf changed the title Why do we add 2 in LSTM logsumexp? Make LSTM more LSTM-like Oct 24, 2019
@awf
Copy link
Contributor

awf commented Oct 24, 2019

Yes that is very odd, and doesn't ring a bell. Let's also make this issue track other LSTM oddnesses: diagonal weight matrix. Any more?

tomjaguarpaw pushed a commit that referenced this issue Oct 30, 2019
@toelli-msft
Special-case display of "LSTM" name
bfb9818 
because of #143

Eventually we plan to change to a standard LSTM formulation
@tomjaguarpaw tomjaguarpaw mentioned this issue Oct 30, 2019
Merged
tomjaguarpaw pushed a commit that referenced this issue Nov 4, 2019
@toelli-msft @tomjaguarpaw
Special-case display of "LSTM" name
92f1b3a 
because of #143

Eventually we plan to change to a standard LSTM formulation
@toelli-msft toelli-msft mentioned this issue Nov 14, 2019
Merged
@awf awf changed the title Make LSTM more LSTM-like EXT: Make LSTM more LSTM-like Dec 18, 2019
@tomjaguarpaw tomjaguarpaw changed the title EXT: Make LSTM more LSTM-like Make LSTM more LSTM-like Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@awf awf

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@awf @tomjaguarpaw