Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ObjectMapper from context #768

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Use ObjectMapper from context #768

merged 2 commits into from
Jan 10, 2024

Conversation

yawkat
Copy link
Member

@yawkat yawkat commented Jan 10, 2024

Use the new serde clone API to use the ObjectMapper from the BeanContext for ManagedNettyHttpProvider. This allows adding custom serdes to the mapper.

Jackson remains unsupported for now, because there is no central cloneWithConfiguration API atm.

Fixes #647

Use the new serde clone API to use the ObjectMapper from the BeanContext for ManagedNettyHttpProvider. This allows adding custom serdes to the mapper.

Jackson remains unsupported for now, because there is no central cloneWithConfiguration API atm.

Fixes #647
@yawkat yawkat added the type: improvement A minor improvement to an existing feature label Jan 10, 2024
@yawkat yawkat added this to the 3.3.0 milestone Jan 10, 2024
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
92.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@graemerocher
Copy link
Contributor

does this mean the application and the SDK have to share the same configuration?

@yawkat
Copy link
Member Author

yawkat commented Jan 10, 2024

@graemerocher no it uses a new config key oci.serde

@graemerocher graemerocher merged commit 9794677 into master Jan 10, 2024
19 checks passed
@graemerocher graemerocher deleted the managed-serde branch January 10, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement A minor improvement to an existing feature
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Allow customization of netty http client mapper
3 participants