Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding favicon on user guide pages #146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

caioguedes
Copy link

Fixes #34

The icon file was extracted from the main page of the documentation.

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2023

CLA assistant check
All committers have signed the CLA.

@sdelamo
Copy link
Contributor

sdelamo commented Jan 26, 2024

do we have a favicon.ico you are referencing in this PR?
I assume we will have to copy https://micronaut.io/wp-content/uploads/2021/02/favicon.ico in the img folder

@sdelamo sdelamo closed this Jan 26, 2024
@sdelamo sdelamo reopened this Jan 26, 2024
@caioguedes
Copy link
Author

do we have a favicon.ico you are referencing in this PR? I assume we will have to copy https://micronaut.io/wp-content/uploads/2021/02/favicon.ico in the img folder

Exactly, I extracted the icon from the main page https://micronaut.io/wp-content/uploads/2021/02/favicon.ico, do we should point the icon to this url or the raw url in the git repository?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

favicon is missing from user guide
3 participants