Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistenty in JVM TimedExecutors "executionTimer" #5148

Open
OOP-778 opened this issue May 26, 2024 · 1 comment
Open

Inconsistenty in JVM TimedExecutors "executionTimer" #5148

OOP-778 opened this issue May 26, 2024 · 1 comment
Labels
breaking-change instrumentation An issue that is related to instrumenting a component
Milestone

Comments

@OOP-778
Copy link

OOP-778 commented May 26, 2024

Describe the bug
TimedExecutor has "executor.execution" whilst all other implementations just have "executor"

Environment

  • Micrometer version 1.13.0

To Reproduce
Just check the code :P

Expected behavior
Other implementations of TimedExecutors should have "executor.execution" for execution timers for consistency sake.

@jonatan-ivanov
Copy link
Member

Thanks for the issue, it would help if you could link the code you want us to check.
(There is no TimedExecutors in Micrometer and TimedExecutor is a class, it does not have any implementations.)
Do you mean these?

Did you find more?
Making them consistent is a breaking change which I don't think we can do in 1.x but you can rename them in your app using a MeterFilter.

@jonatan-ivanov jonatan-ivanov added instrumentation An issue that is related to instrumenting a component breaking-change and removed waiting-for-triage labels Jul 2, 2024
@jonatan-ivanov jonatan-ivanov added this to the 2.x milestone Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change instrumentation An issue that is related to instrumenting a component
Projects
None yet
Development

No branches or pull requests

2 participants