-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata file support #130
Comments
This comment was marked as outdated.
This comment was marked as outdated.
I want to do this on a custom KeyValues enum:
Right now we need to supply a plain string on the asString method. |
@ttddyy , thats a great idea, I like it more than what I proposed in #80. |
I think we're all in agreement this would be a really neat feature with a lot of possible benefits/use. I've marked it as |
Currently, docs-gen can only generate asciidoc files based on the existing source code files.
To make this project more useful, also as raised in #80, it should support metadata files.
docs-gen project(or else) should do two things:
For metadata, it would be something like this:
The creation of documentation should be able to specify what groups of metadata to be included/excluded.
For example, a doc is created with all metadata or specific metadata files in the classpath or file system.
Things to consider:
Define metadata format
This could be based on the current model classes(
SpanEntry
,MetricEntry
,ObservationConventionEntry
)Hookup the docs-gen to maven and gradle lifecycle
In order to include the metadata files in the generating jar, the metadata generation needs to happen before jar creation.
Allow manual metadata
Similar to
additional-spring-configuration-metadata
in Spring Boot, allows users to provide a manual metadata file.Resolve model classes from metadata
When the' ObservationConvention' class references classes in dependent jars, those jars may have metadata files.
The referenced model resolution needs to be extended to consider the metadata files in jars in addition to the source files within the project.
Metadata inclusion/exclusion
When generating documents, provide filtering(include/exclude) by jar files(?), metadata name, package, etc.
The text was updated successfully, but these errors were encountered: