Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make site more POSH #59

Open
btrem opened this issue Dec 2, 2022 · 1 comment
Open

make site more POSH #59

btrem opened this issue Dec 2, 2022 · 1 comment

Comments

@btrem
Copy link
Contributor

btrem commented Dec 2, 2022

The markup relies on lots of divs where more semantic markup would be more appropriate:

  • header instead of div.jumbotron
  • figure instead of div.card
  • etc.

Also, I don't think the bootstrap css is really necessary. For one thing, it's a pretty simple one page site. For another, modern css can do what bootstrap does, much more simply. Making these changes would provide a better example for anyone who views source of microformats.io, and would also resolve #29 (I think).

@btrem btrem mentioned this issue Dec 2, 2022
Closed
@btrem
Copy link
Contributor Author

btrem commented Dec 7, 2022

@gRegorLove I closed PR #60 because of the merge conflicts, and am starting over. But this time, I'm going to break up the work into smaller bits that you can more easily review, starting with #61.

More to come. I have done some work to normalize indentation and spacing of the source code (not the visible code examples), just to make it easier to work on the html.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant